This revision was automatically updated to reflect the committed changes.
Closed by commit rL295304: [clangd] Implement format on type (authored by
krasimir).
Changed prior to commit:
https://reviews.llvm.org/D29990?vs=88703&id=88708#toc
Repository:
rL LLVM
https://reviews.llvm.org/D29990
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D29990
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
krasimir updated this revision to Diff 88703.
krasimir edited the summary of this revision.
krasimir added a comment.
- Address review comments
https://reviews.llvm.org/D29990
Files:
clangd/ClangDMain.cpp
clangd/Protocol.cpp
clangd/Protocol.h
clangd/ProtocolHandlers.cpp
clangd/Protoco
bkramer added inline comments.
Comment at: clangd/ProtocolHandlers.cpp:117
+ // starting from there.
+ StringRef Code = Store.getDocument(DOTFP->textDocument.uri);
+ size_t CursorPos = positionToOffset(Code, DOTFP->position);
This should be a std::string in tr
