[PATCH] D30034: [clang-tidy] Fix a false positive for explicit template instantiations in misc-unused-using-decls.
alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. I think, we decided to extend the AST instead of working around its incompleteness. https://reviews.llvm.org/D30034 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D30034: [clang-tidy] Fix a false positive for explicit template instantiations in misc-unused-using-decls.
alexfh added a comment. Richard, it seems like the AST could be improved here by adding nodes for the explicit instantiation declarations and definitions or using existing nodes, if there are suitable ones. What do you think? https://reviews.llvm.org/D30034 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D30034: [clang-tidy] Fix a false positive for explicit template instantiations in misc-unused-using-decls.
alexfh added a comment. > it may introduce true positives True positives is all we need from clang-tidy checks ;) I guess, you meant "false negatives" (https://en.wikipedia.org/wiki/False_positives_and_false_negatives). The main question here is whether we should extend the AST instead of hacking around its limitations. It's probably best to discuss with Richard Smith. https://reviews.llvm.org/D30034 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
