rmaprath marked an inline comment as done.
rmaprath added a comment.
Thanks!
Committed as r295963.
@gkistanova: Could you please let me know when the next restart is due? I would
like to keep an eye on the builders.
Cheers,
/ Asiri
Repository:
rL LLVM
https://reviews.llvm.org/D30290
This revision was automatically updated to reflect the committed changes.
Closed by commit rL295963: [zorg] Fix no-exceptions libcxx configurations
(authored by asiri).
Changed prior to commit:
https://reviews.llvm.org/D30290?vs=89485=89496#toc
Repository:
rL LLVM
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
I'll add a local task to look into that, but with Connect coming, I'm not sure
how long that will take. :)
https://reviews.llvm.org/D30290
rmaprath marked an inline comment as done.
rmaprath added inline comments.
Comment at: buildbot/osuosl/master/config/builders.py:1196
+lit_extra_opts={'link_flags': '"-lc++abi -lc -lm -lpthread -ldl
-L/opt/llvm/lib/clang/3.9.0/lib/linux -lclang_rt.builtins-armhf"'},
rmaprath updated this revision to Diff 89485.
rmaprath added a comment.
Updated to address comments from @rengolin.
In theory, it should not be necessary to link-in or enable the unwinder for
these tests. However, it is best to leave this for a separate patch (after some
local testing), just
rengolin added inline comments.
Comment at: buildbot/osuosl/master/config/builders.py:1196
+lit_extra_opts={'link_flags': '"-lc++abi -lc -lm -lpthread -ldl
-L/opt/llvm/lib/clang/3.9.0/lib/linux -lclang_rt.builtins-armhf"'},
+
rmaprath added inline comments.
Comment at: buildbot/osuosl/master/config/builders.py:1196
+lit_extra_opts={'link_flags': '"-lc++abi -lc -lm -lpthread -ldl
-L/opt/llvm/lib/clang/3.9.0/lib/linux -lclang_rt.builtins-armhf"'},
+
rengolin added inline comments.
Comment at: buildbot/osuosl/master/config/builders.py:1196
+lit_extra_opts={'link_flags': '"-lc++abi -lc -lm -lpthread -ldl
-L/opt/llvm/lib/clang/3.9.0/lib/linux -lclang_rt.builtins-armhf"'},
+
rmaprath created this revision.
Herald added a reviewer: EricWF.
The no-exceptions builders are missing the -DLIBCXXABI_ENABLE_EXCEPTIONS=OFF
flag (without this, only the libc++ libraries will be built without exceptions
support, libc++abi will still be built with exceptions support - this is
