[PATCH] D30378: [DebugInfo] [DWARFv5] Collect calling convention info for C++ types during codegen

2017-02-27 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:955-957 +// DWARFv5 doesn't specify explicit DW_CC_* value for this case, +// thus we just return 'normal' here. +return llvm::dwarf::DW_CC_normal; dblaikie wrote: > Could you

[PATCH] D30378: [DebugInfo] [DWARFv5] Collect calling convention info for C++ types during codegen

2017-02-27 Thread Victor Leschuk via Phabricator via cfe-commits
vleschuk added inline comments. Comment at: test/CodeGenCXX/debug-info-type-calling-conventions.cpp:11-12 + +class UserDtor { +public: + ~UserDtor() {} dblaikie wrote: > I'd probably make this a struct (and drop the 'public:' section since it'll > be the

[PATCH] D30378: [DebugInfo] [DWARFv5] Collect calling convention info for C++ types during codegen

2017-02-27 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. Be best to avoid having to 'fixup' the argabi after the fact - and instead build the type with the right argabi from the get-go. Comment at: lib/CodeGen/CGDebugInfo.cpp:955-957 +// DWARFv5 doesn't specify explicit DW_CC_* value for this case, +

[PATCH] D30378: [DebugInfo] [DWARFv5] Collect calling convention info for C++ types during codegen

2017-02-25 Thread Victor Leschuk via Phabricator via cfe-commits
vleschuk created this revision. When generating debug info collect information on calling convention for types (http://www.dwarfstd.org/ShowIssue.php?issue=141215.1) and pass it to backend. https://reviews.llvm.org/D30378 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h