sdardis closed this revision.
sdardis added a comment.
Closing this, https://reviews.llvm.org/rL297098.
Repository:
rL LLVM
https://reviews.llvm.org/D30465
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
sdardis added a comment.
FYI, you should close this revision manually and cite the commit
(https://reviews.llvm.org/rL297098). Also please cite the review and all the
reviewers when you commit. E.g. the commit message for that should be:
[mips] Set the Int64Type / IntMaxType types correctly for
sdardis added a comment.
Do you need me to commit this for you?
Repository:
rL LLVM
https://reviews.llvm.org/D30465
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
brad added a comment.
Good to know about the reviewer.
I am not familiar with phabricator and was just trying something with the
addition of the subscriber.
I will keep the amount of context in mind for future diffs.
Thanks.
Repository:
rL LLVM
https://reviews.llvm.org/D30465
_
sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.
This wasn't trapped by my filters when it was first posted - sorry about that.
In future if it's a mips related patch you can add me directly as a reviewer
when posting the patch. Changing t
brad added a comment.
ping?
Repository:
rL LLVM
https://reviews.llvm.org/D30465
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
brad created this revision.
Set the Int64Type / IntMaxType types correctly for OpenBSD/mips64
Repository:
rL LLVM
https://reviews.llvm.org/D30465
Files:
lib/Basic/Targets.cpp
test/Preprocessor/init.c
Index: test/Preprocessor/init.c
==
