kastiglione added a comment.
@aaron.ballman @malcolm.parsons Thanks for the reviews and the commit. I plan
to do follow ups for more ObjC ASTMatcher support.
https://reviews.llvm.org/D30854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
aaron.ballman closed this revision.
aaron.ballman added a comment.
I've commit in r297882, thanks!
https://reviews.llvm.org/D30854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM! I'll go ahead and commit for you.
Comment at: unittests/ASTMatchers/ASTMatchersTest.h:114
+const std::string = "input.cc") {
+ return matchesConditionally(
+Code, AMatcher, ExpectMatch,
kastiglione added inline comments.
Comment at: unittests/ASTMatchers/ASTMatchersTest.h:64
const std::string , const T , bool ExpectMatch,
-llvm::StringRef CompileArg,
+std::vector Args,
const FileContentMappings = FileContentMappings(),
kastiglione updated this revision to Diff 91914.
kastiglione added a comment.
Use ArrayRef
https://reviews.llvm.org/D30854
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unittests/ASTMatchers/ASTMatchersNodeTest.cpp
aaron.ballman added inline comments.
Comment at: unittests/ASTMatchers/ASTMatchersTest.h:64
const std::string , const T , bool ExpectMatch,
-llvm::StringRef CompileArg,
+std::vector Args,
const FileContentMappings = FileContentMappings(),
kastiglione added inline comments.
Comment at: unittests/ASTMatchers/ASTMatchersTest.h:64
const std::string , const T , bool ExpectMatch,
-llvm::StringRef CompileArg,
+std::vector Args,
const FileContentMappings = FileContentMappings(),
aaron.ballman added inline comments.
Comment at: unittests/ASTMatchers/ASTMatchersTest.h:64
const std::string , const T , bool ExpectMatch,
-llvm::StringRef CompileArg,
+std::vector Args,
const FileContentMappings = FileContentMappings(),
I
kastiglione updated this revision to Diff 91801.
kastiglione added a comment.
Overload matchesConditionally() for multiple compiler args
https://reviews.llvm.org/D30854
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
aaron.ballman added inline comments.
Comment at: unittests/ASTMatchers/ASTMatchersNodeTest.cpp:1547
+ std::string ObjCString =
+"#pragma clang diagnostic ignored \"-Wobjc-root-class\"\n"
+"@protocol Proto "
kastiglione wrote:
> aaron.ballman wrote:
> >
kastiglione added inline comments.
Comment at: unittests/ASTMatchers/ASTMatchersNodeTest.cpp:1547
+ std::string ObjCString =
+"#pragma clang diagnostic ignored \"-Wobjc-root-class\"\n"
+"@protocol Proto "
aaron.ballman wrote:
> kastiglione wrote:
> >
aaron.ballman added inline comments.
Comment at: unittests/ASTMatchers/ASTMatchersNodeTest.cpp:1547
+ std::string ObjCString =
+"#pragma clang diagnostic ignored \"-Wobjc-root-class\"\n"
+"@protocol Proto "
kastiglione wrote:
> kastiglione wrote:
> >
kastiglione updated this revision to Diff 91740.
kastiglione added a comment.
Use -fobjc-nonfragile-abi
https://reviews.llvm.org/D30854
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
kastiglione added inline comments.
Comment at: unittests/ASTMatchers/ASTMatchersNodeTest.cpp:1547
+ std::string ObjCString =
+"#pragma clang diagnostic ignored \"-Wobjc-root-class\"\n"
+"@protocol Proto "
kastiglione wrote:
> aaron.ballman wrote:
> >
kastiglione added inline comments.
Comment at: unittests/ASTMatchers/ASTMatchersNodeTest.cpp:1501
- std::string Objc1String =
+ std::string ObjCString =
+"#pragma clang diagnostic ignored \"-Wobjc-root-class\"\n"
aaron.ballman wrote:
> These changes are
aaron.ballman added inline comments.
Comment at: unittests/ASTMatchers/ASTMatchersNodeTest.cpp:1501
- std::string Objc1String =
+ std::string ObjCString =
+"#pragma clang diagnostic ignored \"-Wobjc-root-class\"\n"
These changes are unrelated and should
kastiglione added a comment.
Thanks @malcolm.parsons. I don't have commit access, will you be able to commit
this?
https://reviews.llvm.org/D30854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
malcolm.parsons accepted this revision.
malcolm.parsons added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D30854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
kastiglione added a comment.
I'd like to add more ObjC specific matcher functionality in follow up diffs.
This diff is to to start somewhere, and get feedback.
https://reviews.llvm.org/D30854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
kastiglione created this revision.
This adds matchers for `ObjCProtocolDecl`, `ObjCCategoryDecl`,
`ObjCMethodDecl`, `ObjCIvarDecl`, and
`ObjCPropertyDecl`. These matchers complement the existing matcher for
`ObjCInterfaceDecl`.
https://reviews.llvm.org/D30854
Files:
20 matches
Mail list logo
