This revision was automatically updated to reflect the committed changes.
vsapsai marked an inline comment as done.
Closed by commit rL331319: Track skipped files in dependency scanning.
(authored by vsapsai, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Thanks for the detailed answers. LGTM
https://reviews.llvm.org/D30881
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
vsapsai marked 2 inline comments as done.
vsapsai added inline comments.
Comment at: lib/Frontend/DependencyFile.cpp:191
+ const Token ,
+ SrcMgr::CharacteristicKind FileType) override;
+
bruno wrote:
> Is there any
vsapsai updated this revision to Diff 144802.
vsapsai added a comment.
- Fix FileSkipped adding system headers when it shouldn't.
https://reviews.llvm.org/D30881
Files:
clang/lib/Frontend/DependencyFile.cpp
clang/test/Frontend/Inputs/SystemHeaderPrefix/with-header-guard.h
vsapsai added a comment.
I plan to look into cleaning this up and addressing the review comments.
Need to check if `DepCollectorPPCallbacks` has to be updated too.
Comment at: lib/Frontend/DependencyFile.cpp:302
+ SrcMgr::CharacteristicKind FileType) {
+
bruno added a comment.
Hi Pete,
Comment at: lib/Frontend/DependencyFile.cpp:191
+ const Token ,
+ SrcMgr::CharacteristicKind FileType) override;
+
Is there any `FileSkipped` callback invocation that might trigger an unwanted
pete created this revision.
Its possible for a header to be a symlink to another header. In this case,
both are actually the same underlying file, and will both have the same include
guards.
Because of this, if we #include the header, then #include the symlink, or vice
versa, then one will
