[PATCH] D31375: Add docs for libunwind

jroelofs added a comment. Review for adding a builder in: https://reviews.llvm.org/D31422 https://reviews.llvm.org/D31375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31375: Add docs for libunwind

jroelofs closed this revision. jroelofs added a comment. r298922 https://reviews.llvm.org/D31375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31375: Add docs for libunwind

jroelofs added a comment. In https://reviews.llvm.org/D31375#712152, @jroelofs wrote: > In https://reviews.llvm.org/D31375#711839, @EricWF wrote: > > > In https://reviews.llvm.org/D31375#710897, @jroelofs wrote: > > > > > In https://reviews.llvm.org/D31375#710891, @compnerd wrote: > > > > > > >

[PATCH] D31375: Add docs for libunwind

jroelofs added a comment. In https://reviews.llvm.org/D31375#711839, @EricWF wrote: > In https://reviews.llvm.org/D31375#710897, @jroelofs wrote: > > > In https://reviews.llvm.org/D31375#710891, @compnerd wrote: > > > > > What happens when you try building it in tree? > > > > > > The

[PATCH] D31375: Add docs for libunwind

EricWF added a comment. In https://reviews.llvm.org/D31375#710897, @jroelofs wrote: > In https://reviews.llvm.org/D31375#710891, @compnerd wrote: > > > What happens when you try building it in tree? > > > The docs-libunwind-html target is missing, and the docs don't get built. Shouldn't that

[PATCH] D31375: Add docs for libunwind

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. This LGTM. We should also get a bot setup to build it. https://reviews.llvm.org/D31375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31375: Add docs for libunwind

jroelofs updated this revision to Diff 93075. https://reviews.llvm.org/D31375 Files: CMakeLists.txt docs/BuildingLibunwind.rst docs/CMakeLists.txt docs/README.txt docs/conf.py docs/index.rst Index: docs/index.rst ===

[PATCH] D31375: Add docs for libunwind

jroelofs added a comment. In https://reviews.llvm.org/D31375#710891, @compnerd wrote: > What happens when you try building it in tree? The docs-libunwind-html target is missing, and the docs don't get built. Comment at: docs/index.rst:82 + +If you want to contribute a patch

[PATCH] D31375: Add docs for libunwind

compnerd added a comment. What happens when you try building it in tree? Comment at: docs/index.rst:82 + +If you want to contribute a patch to libc++, the best place for that is +`Phabricator `_. Please include [libunwind] in the subject

[PATCH] D31375: Add docs for libunwind

jroelofs updated this revision to Diff 93074. https://reviews.llvm.org/D31375 Files: CMakeLists.txt docs/BuildingLibunwind.rst docs/CMakeLists.txt docs/README.txt docs/conf.py docs/index.rst Index: docs/index.rst ===

[PATCH] D31375: Add docs for libunwind

krytarowski added inline comments. Comment at: docs/index.rst:51 +LinuxARM Clang, GCC EHABI +Bare Metal ARM Clang, GCC EHABI + NetBSD amd64

[PATCH] D31375: Add docs for libunwind

jroelofs created this revision. Herald added a subscriber: mgorny. I'm still iffy about the build goop for this. I started mostly cargo-culting the stuff from libcxx, but couldn't get that to work. What's in the patch seems to work for the standalone build, but does not work for in tree builds