This revision was automatically updated to reflect the committed changes.
Closed by commit rL305272: clang-format: add option to merge empty function
body (authored by Typz).
Changed prior to commit:
https://reviews.llvm.org/D33447?vs=100420=102294#toc
Repository:
rL LLVM
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D33447
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Typz added a comment.
ping?
https://reviews.llvm.org/D33447
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Typz added a comment.
ping
https://reviews.llvm.org/D33447
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Typz updated this revision to Diff 100420.
Typz marked 2 inline comments as done.
Typz added a comment.
fix indent & rename option to SplitEmptyFunctionBody
https://reviews.llvm.org/D33447
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/UnwrappedLineFormatter.cpp
djasper added inline comments.
Comment at: include/clang/Format/Format.h:644
+/// This option is used only if the opening brace of the function has
+/// already
+/// been wrapped, i.e. the `AfterFunction` brace wrapping mode is set, and
Reflow the
Typz updated this revision to Diff 100412.
Typz added a comment.
move option to BraceWrapping
https://reviews.llvm.org/D33447
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/UnwrappedLineFormatter.cpp
unittests/Format/FormatTest.cpp
Index:
djasper added a comment.
Lets try this the other way around. I am not ok with introducing an additional
top-level option for this. It simply isn't important enough. So find a way for
the existing style flags to support what you need and not regress existing
users. If that can't be done, I am
Typz added a comment.
In https://reviews.llvm.org/D33447#765610, @djasper wrote:
> I think it's just wrong that WebKit inherits this. The style guide explicitly
> says that this is wrong:
>
> MyOtherClass::MyOtherClass() : MySuperClass() {}
I think this exemple applies to constructors only.
djasper added a comment.
I think it's just wrong that WebKit inherits this. The style guide explicitly
says that this is wrong:
MyOtherClass::MyOtherClass() : MySuperClass() {}
So I still think we can make this work with the existing options without
regressing a behavior that anyone is
Typz updated this revision to Diff 100393.
Typz added a comment.
update mozilla style to use empty function blocks
https://reviews.llvm.org/D33447
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/UnwrappedLineFormatter.cpp
unittests/Format/FormatTest.cpp
Index:
Typz added a comment.
Webkit inherits AllowShortFunctionsOnASingleLine = FormatStyle::SFS_All from
LLVM style, so merging the options would introduce these explicitely-forbidden
empty blocks.
But the empty blocks should actually be used in code following Mozilla or Qt
style.
djasper added a comment.
I don't understand. WebKit style would not set AllowShortFunctionsOnASingleLine
and so the behavior there wouldn't change, I presume?
https://reviews.llvm.org/D33447
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
13 matches
Mail list logo
