[PATCH] D34256: [PR33394] Avoid lexing editor placeholders when running the preprocessor only

This revision was automatically updated to reflect the committed changes. Closed by commit rL305576: [PR33394] Avoid lexing editor placeholders when Clang is used only (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D34256?vs=102764=102862#toc Repository: rL LLVM

[PATCH] D34256: [PR33394] Avoid lexing editor placeholders when running the preprocessor only

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rL LLVM https://reviews.llvm.org/D34256 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34256: [PR33394] Avoid lexing editor placeholders when running the preprocessor only

arphaman updated this revision to Diff 102764. arphaman added a comment. Fair enough. I removed the special checks for `<#>` and `<##>`. Repository: rL LLVM https://reviews.llvm.org/D34256 Files: include/clang/Lex/PreprocessorOptions.h lib/Frontend/CompilerInvocation.cpp

[PATCH] D34256: [PR33394] Avoid lexing editor placeholders when running the preprocessor only

benlangmuir added a comment. I agree with not detecting these during PP-only, but there's nothing wrong with `<#>`. It's either not a placeholder, or it's part of a placeholder like `<#>#>`, which is a placeholder containing the text ">". Similarly, `<##` could be the start of an empty

[PATCH] D34256: [PR33394] Avoid lexing editor placeholders when running the preprocessor only

arphaman created this revision. r300667 added support for editor placeholder to Clang. That commit didn’t take into account that users who use Clang for preprocessing only (-E) will get the “editor placeholder in source file” error when preprocessing their source (PR33394). This commit