[PATCH] D34860: [Objective-C] Fix non-determinism in clang

2017-07-06 Thread Mandeep Singh Grang via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL307296: [Objective-C] Fix non-determinism in clang (authored by mgrang). Changed prior to commit: https://reviews.llvm.org/D34860?vs=104811=105498#toc Repository: rL LLVM

[PATCH] D34860: [Objective-C] Fix non-determinism in clang

2017-07-05 Thread David Blaikie via Phabricator via cfe-commits
dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds plausible to me https://reviews.llvm.org/D34860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34860: [Objective-C] Fix non-determinism in clang

2017-07-05 Thread Mandeep Singh Grang via Phabricator via cfe-commits
mgrang added a comment. Ping for reviews please. https://reviews.llvm.org/D34860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34860: [Objective-C] Fix non-determinism in clang

2017-06-29 Thread Mandeep Singh Grang via Phabricator via cfe-commits
mgrang created this revision. Iteration of the unordered Ivars causes objc-modern-metadata-visibility.mm (uncovered by reverse iterating SmallPtrSet). https://reviews.llvm.org/D34860 Files: lib/Frontend/Rewrite/RewriteModernObjC.cpp test/Rewriter/objc-modern-metadata-visibility2.mm