[PATCH] D35406: [clangd] Replace ASTUnit with manual AST management.

ilya-biryukov added a comment. In https://reviews.llvm.org/D35406#821567, @petarj wrote: > Can you check if this change introduced clang-x86-windows-msvc2015 buildbot > failure > ? It did. Was fixed in r308959

[PATCH] D35406: [clangd] Replace ASTUnit with manual AST management.

petarj added a comment. Can you check if this change introduced clang-x86-windows-msvc2015 buildbot failure ? Repository: rL LLVM https://reviews.llvm.org/D35406 ___

[PATCH] D35406: [clangd] Replace ASTUnit with manual AST management.

This revision was automatically updated to reflect the committed changes. Closed by commit rL308738: [clangd] Replace ASTUnit with manual AST management. (authored by ibiryukov). Changed prior to commit: https://reviews.llvm.org/D35406?vs=107475=107666#toc Repository: rL LLVM

[PATCH] D35406: [clangd] Replace ASTUnit with manual AST management.

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Looks good! https://reviews.llvm.org/D35406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35406: [clangd] Replace ASTUnit with manual AST management.

ilya-biryukov updated this revision to Diff 107475. ilya-biryukov added a comment. Added a few comments. https://reviews.llvm.org/D35406 Files: clangd/ClangdServer.cpp clangd/ClangdUnit.cpp clangd/ClangdUnit.h Index: clangd/ClangdUnit.h

[PATCH] D35406: [clangd] Replace ASTUnit with manual AST management.

ilya-biryukov added inline comments. Comment at: clangd/ClangdUnit.cpp:167 +std::move(VFS)); + CI->getFrontendOpts().DisableFree = false; + return CI; krasimir wrote: > Why `DisableFree`? We rely on CompilerInstance

[PATCH] D35406: [clangd] Replace ASTUnit with manual AST management.

krasimir added inline comments. Comment at: clangd/ClangdUnit.cpp:167 +std::move(VFS)); + CI->getFrontendOpts().DisableFree = false; + return CI; Why `DisableFree`? Comment at:

[PATCH] D35406: [clangd] Replace ASTUnit with manual AST management.

ilya-biryukov added a comment. In https://reviews.llvm.org/D35406#809623, @malaperle wrote: > For synching with what I am doing. I am "only" looking right now at the > modeling of the index and its on-disk storage, not really on the speeding up > of the parsing of the TUs (i.e. the input of

[PATCH] D35406: [clangd] Replace ASTUnit with manual AST management.

malaperle added a comment. In https://reviews.llvm.org/D35406#809609, @ilya-biryukov wrote: > The idea is to allows us changing the way we manage/rebuild PCHs and ASTs. > ASTUnit is used for many things and has a fairly complicated and verbose > interface and does a lot of mutations all other

[PATCH] D35406: [clangd] Replace ASTUnit with manual AST management.

ilya-biryukov added a comment. The idea is to allows us changing the way we manage/rebuild PCHs and ASTs. ASTUnit is used for many things and has a fairly complicated and verbose interface and does a lot of mutations all other the place inside it, so making changes to it is not particularly

[PATCH] D35406: [clangd] Replace ASTUnit with manual AST management.

malaperle added a comment. Could you explain what the goal of this change is? It would help understand how it will impact the indexing work I am currently doing. https://reviews.llvm.org/D35406 ___ cfe-commits mailing list

[PATCH] D35406: [clangd] Replace ASTUnit with manual AST management.

ilya-biryukov updated this revision to Diff 106632. ilya-biryukov added a comment. - Replaced TODO with FIXME in a comment. https://reviews.llvm.org/D35406 Files: clangd/ClangdServer.cpp clangd/ClangdUnit.cpp clangd/ClangdUnit.h Index: clangd/ClangdUnit.h

[PATCH] D35406: [clangd] Replace ASTUnit with manual AST management.

ilya-biryukov added a comment. Depends on change to cfe (https://reviews.llvm.org/D35405) to compile properly. https://reviews.llvm.org/D35406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35406: [clangd] Replace ASTUnit with manual AST management.

ilya-biryukov created this revision. This refactoring does not aim to introduce any significant changes to the behaviour of clangd to keep the change as simple as possible. https://reviews.llvm.org/D35406 Files: clangd/ClangdServer.cpp clangd/ClangdUnit.cpp clangd/ClangdUnit.h Index: