This revision was automatically updated to reflect the committed changes.
Closed by commit rL311669: [mips] Introducing option -mabs=[legacy/2008]
(authored by petarj).
Changed prior to commit:
https://reviews.llvm.org/D35982?vs=112534&id=112571#toc
Repository:
rL LLVM
https://reviews.llvm.
abeserminji updated this revision to Diff 112534.
abeserminji added a comment.
Added test //test/Driver/mips-mabs-warning.c// as suggested in comments.
Repository:
rL LLVM
https://reviews.llvm.org/D35982
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Basic/DiagnosticGr
sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.
LGTM with a test for warnings. See test/Driver/mips-abicalls.c for reference.
Repository:
rL LLVM
https://reviews.llvm.org/D35982
___
cfe-co
abeserminji updated this revision to Diff 111492.
abeserminji added a comment.
On @atanasyan 's suggestion, part of the patch is separated here
https://reviews.llvm.org/D36824.
Comments resolved.
Repository:
rL LLVM
https://reviews.llvm.org/D35982
Files:
include/clang/Basic/DiagnosticDri
sdardis requested changes to this revision.
sdardis added a comment.
This revision now requires changes to proceed.
Follow @atanasyan 's suggestion and post a patch that renames that enum along
with other changes.
One comment inlined.
Comment at: clang/Basic/DiagnosticDriverK
atanasyan added a comment.
Is it possible to factor out Nan => IEEE754 renaming into the separate patch?
Repository:
rL LLVM
https://reviews.llvm.org/D35982
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
abeserminji created this revision.
Herald added a subscriber: arichardson.
In patch https://reviews.llvm.org/D3274 using abs.[ds] instruction is forced,
as they should behave in accordance with flags Has2008 and ABS2008.
Unfortunately for revisions prior mips32r6 and mips64r6, abs.[ds] is not
g
