[PATCH] D36349: [CMake] Build sanitized C++ runtimes for Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rL311033: [CMake] Build sanitized C++ runtimes for Fuchsia (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D36349?vs=110311=111399#toc Repository: rL LLVM

[PATCH] D36349: [CMake] Build sanitized C++ runtimes for Fuchsia

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. This also looks good to me. Repository: rL LLVM https://reviews.llvm.org/D36349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36349: [CMake] Build sanitized C++ runtimes for Fuchsia

phosek updated this revision to Diff 110311. Repository: rL LLVM https://reviews.llvm.org/D36349 Files: cmake/caches/Fuchsia-stage2.cmake Index: cmake/caches/Fuchsia-stage2.cmake === --- cmake/caches/Fuchsia-stage2.cmake +++

[PATCH] D36349: [CMake] Build sanitized C++ runtimes for Fuchsia

phosek added inline comments. Comment at: cmake/caches/Fuchsia-stage2.cmake:56 +foreach(target x86_64;aarch64) + set(RUNTIMES_${target}-fuchsia-asan_CMAKE_BUILD_WITH_INSTALL_RPATH ON CACHE BOOL "") mcgrathr wrote: > Can you do this without duplicating all

[PATCH] D36349: [CMake] Build sanitized C++ runtimes for Fuchsia

mcgrathr added inline comments. Comment at: cmake/caches/Fuchsia-stage2.cmake:56 +foreach(target x86_64;aarch64) + set(RUNTIMES_${target}-fuchsia-asan_CMAKE_BUILD_WITH_INSTALL_RPATH ON CACHE BOOL "") Can you do this without duplicating all the identical

[PATCH] D36349: [CMake] Build sanitized C++ runtimes for Fuchsia

phosek updated this revision to Diff 109852. Repository: rL LLVM https://reviews.llvm.org/D36349 Files: cmake/caches/Fuchsia-stage2.cmake Index: cmake/caches/Fuchsia-stage2.cmake === --- cmake/caches/Fuchsia-stage2.cmake +++

[PATCH] D36349: [CMake] Build sanitized C++ runtimes for Fuchsia

phosek created this revision. Herald added a subscriber: mgorny. Repository: rL LLVM https://reviews.llvm.org/D36349 Files: cmake/caches/Fuchsia-stage2.cmake Index: cmake/caches/Fuchsia-stage2.cmake === ---