[PATCH] D36452: [clang-tidy] Fix another crash in make-unique check.

2017-08-09 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL310496: [clang-tidy] Fix another crash in make-unique check. (authored by hokein). Repository: rL LLVM https://reviews.llvm.org/D36452 Files:

[PATCH] D36452: [clang-tidy] Fix another crash in make-unique check.

2017-08-09 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Thank you for the fix! Looks good! Comment at: test/clang-tidy/modernize-make-unique.cpp:419 + +class UniqueFoo : public std::unique_ptr { + public: I

[PATCH] D36452: [clang-tidy] Fix another crash in make-unique check.

2017-08-08 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. Herald added subscribers: xazax.hun, JDevlieghere. The crash happens when calling `reset` method without any preceding operation like "->" or ".", this could happen in a subclass of the "std::unique_ptr". https://reviews.llvm.org/D36452 Files: