[PATCH] D37134: [libc++] Rerun ranlib manually after merging the static libraries

2017-09-12 Thread Martin Storsjö via Phabricator via cfe-commits 
mstorsjo added a comment.

In https://reviews.llvm.org/D37134#868497, @EricWF wrote:

> Ironically I think parts of this change should be moved into 
> `merge_archives.py`.
>
> > the ar used in merge_archives.py might not be the right one for the target
>
> OK, then we should modify `merge_archives.py` to support optionally 
> specifying the `ar` executable.
>
> >   (and the invocation doesn't include the 's' modifier for updating the 
> > archive index)
>
> Isn't this also just a bug in `merge_archives.py`?


Hm, indeed, that's probably a better solution. I'll give that a go and see how 
it goes.


https://reviews.llvm.org/D37134



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37134: [libc++] Rerun ranlib manually after merging the static libraries

2017-09-12 Thread Eric Fiselier via Phabricator via cfe-commits 
EricWF requested changes to this revision.
EricWF added a comment.

Ironically I think parts of this change should be moved into 
`merge_archives.py`.

> the ar used in merge_archives.py might not be the right one for the target

OK, then we should modify `merge_archives.py` to support optionally specifying 
the `ar` executable.

>   (and the invocation doesn't include the 's' modifier for updating the 
> archive index)

Isn't this also just a bug in `merge_archives.py`?


https://reviews.llvm.org/D37134



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37134: [libc++] Rerun ranlib manually after merging the static libraries

2017-09-09 Thread Martin Storsjö via Phabricator via cfe-commits 
mstorsjo added a comment.

Ping @EricWF


https://reviews.llvm.org/D37134



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37134: [libc++] Rerun ranlib manually after merging the static libraries

2017-09-04 Thread Saleem Abdulrasool via Phabricator via cfe-commits 
compnerd requested changes to this revision.
compnerd added a comment.
This revision now requires changes to proceed.

If we handle this in CMake, this will be unnecessary.


https://reviews.llvm.org/D37134



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37134: [libc++] Rerun ranlib manually after merging the static libraries

2017-09-03 Thread Martin Storsjö via Phabricator via cfe-commits 
mstorsjo added a comment.

Ping


https://reviews.llvm.org/D37134



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37134: [libc++] Rerun ranlib manually after merging the static libraries

2017-08-25 Thread Martin Storsjö via Phabricator via cfe-commits 
mstorsjo created this revision.
Herald added a subscriber: mgorny.

In cross build setups, the ar used in merge_archives.py might not be the right 
one for the target (and the invocation doesn't include the 's' modifier for 
updating the archive index); make sure to rebuild the index for the static 
library.


https://reviews.llvm.org/D37134

Files:
  lib/CMakeLists.txt


Index: lib/CMakeLists.txt
===
--- lib/CMakeLists.txt
+++ lib/CMakeLists.txt
@@ -272,6 +272,8 @@
   "$"
   "${MERGE_ARCHIVES_ABI_TARGET}"
   "${MERGE_ARCHIVES_SEARCH_PATHS}"
+COMMAND
+  ${CMAKE_RANLIB} $
 WORKING_DIRECTORY ${LIBCXX_BUILD_DIR}
 )
   endif()


Index: lib/CMakeLists.txt
===
--- lib/CMakeLists.txt
+++ lib/CMakeLists.txt
@@ -272,6 +272,8 @@
   "$"
   "${MERGE_ARCHIVES_ABI_TARGET}"
   "${MERGE_ARCHIVES_SEARCH_PATHS}"
+COMMAND
+  ${CMAKE_RANLIB} $
 WORKING_DIRECTORY ${LIBCXX_BUILD_DIR}
 )
   endif()
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits