[PATCH] D37804: [OpenCL] Handle address space conversion while setting type alignment

2017-09-27 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. Committed in r314317. Repository: rL LLVM https://reviews.llvm.org/D37804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37804: [OpenCL] Handle address space conversion while setting type alignment

2017-09-27 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. Committed in r314304 In https://reviews.llvm.org/D37804#882252, @alekseyshl wrote: > vectorLoadStore.cl is failing on our bots: > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/8187, > please check it out I will commit a fix in a bit.

[PATCH] D37804: [OpenCL] Handle address space conversion while setting type alignment

2017-09-27 Thread Aleksey Shlyapnikov via Phabricator via cfe-commits
alekseyshl added a comment. vectorLoadStore.cl is failing on our bots: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/8187, please check it out Repository: rL LLVM https://reviews.llvm.org/D37804 ___ cfe-commits mailing

[PATCH] D37804: [OpenCL] Handle address space conversion while setting type alignment

2017-09-27 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL314304: [OpenCL] Handle address space conversion while setting type alignment. (authored by stulova). Changed prior to commit: https://reviews.llvm.org/D37804?vs=116548=116809#toc Repository: rL

[PATCH] D37804: [OpenCL] Handle address space conversion while setting type alignment

2017-09-25 Thread Alexey Bader via Phabricator via cfe-commits
bader accepted this revision. bader added a comment. LGTM. Thanks! https://reviews.llvm.org/D37804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37804: [OpenCL] Handle address space conversion while setting type alignment

2017-09-25 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia updated this revision to Diff 116548. Anastasia added a comment. Addressed comments from Alexey. https://reviews.llvm.org/D37804 Files: lib/CodeGen/CGBuilder.h lib/CodeGen/CGExpr.cpp test/CodeGenOpenCL/vectorLoadStore.cl Index: test/CodeGenOpenCL/vectorLoadStore.cl

[PATCH] D37804: [OpenCL] Handle address space conversion while setting type alignment

2017-09-22 Thread Alexey Bader via Phabricator via cfe-commits
bader added inline comments. Comment at: test/CodeGenOpenCL/vectorLoadStore.cl:7 +typedef float float4 __attribute((ext_vector_type(4))); +; Can we remove this line? Comment at: test/CodeGenOpenCL/vectorLoadStore.cl:15 + +// CHECK: define

[PATCH] D37804: [OpenCL] Handle address space conversion while setting type alignment

2017-09-22 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. https://reviews.llvm.org/D37804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37804: [OpenCL] Handle address space conversion while setting type alignment

2017-09-22 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia updated this revision to Diff 116345. Anastasia added a comment. Created BitCast or AddrSpaceCast conditionally. https://reviews.llvm.org/D37804 Files: lib/CodeGen/CGBuilder.h lib/CodeGen/CGExpr.cpp test/CodeGenOpenCL/vectorLoadStore.cl Index:

[PATCH] D37804: [OpenCL] Handle address space conversion while setting type alignment

2017-09-20 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:957 -return Builder.CreateBitCast(Addr, ConvertType(E->getType())); +return Builder.CreatePointerBitCastOrAddrSpaceCast( +Addr, ConvertType(E->getType())); Anastasia

[PATCH] D37804: [OpenCL] Handle address space conversion while setting type alignment

2017-09-19 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:957 -return Builder.CreateBitCast(Addr, ConvertType(E->getType())); +return Builder.CreatePointerBitCastOrAddrSpaceCast( +Addr, ConvertType(E->getType()));

[PATCH] D37804: [OpenCL] Handle address space conversion while setting type alignment

2017-09-14 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:957 -return Builder.CreateBitCast(Addr, ConvertType(E->getType())); +return Builder.CreatePointerBitCastOrAddrSpaceCast( +Addr, ConvertType(E->getType())); yaxunl

[PATCH] D37804: [OpenCL] Handle address space conversion while setting type alignment

2017-09-13 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:957 -return Builder.CreateBitCast(Addr, ConvertType(E->getType())); +return Builder.CreatePointerBitCastOrAddrSpaceCast( +Addr, ConvertType(E->getType())); Better

[PATCH] D37804: [OpenCL] Handle address space conversion while setting type alignment

2017-09-13 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia created this revision. Added missing `addrspacecast` case in alignment computation logic of pointer type emission in IR generation. https://reviews.llvm.org/D37804 Files: lib/CodeGen/CGExpr.cpp test/CodeGenOpenCL/vectorLoadStore.cl Index: test/CodeGenOpenCL/vectorLoadStore.cl