Anastasia added a comment.
Committed in r314317.
Repository:
rL LLVM
https://reviews.llvm.org/D37804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added a comment.
Committed in r314304
In https://reviews.llvm.org/D37804#882252, @alekseyshl wrote:
> vectorLoadStore.cl is failing on our bots:
> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/8187,
> please check it out
I will commit a fix in a bit.
alekseyshl added a comment.
vectorLoadStore.cl is failing on our bots:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/8187,
please check it out
Repository:
rL LLVM
https://reviews.llvm.org/D37804
___
cfe-commits mailing
This revision was automatically updated to reflect the committed changes.
Closed by commit rL314304: [OpenCL] Handle address space conversion while
setting type alignment. (authored by stulova).
Changed prior to commit:
https://reviews.llvm.org/D37804?vs=116548=116809#toc
Repository:
rL
bader accepted this revision.
bader added a comment.
LGTM. Thanks!
https://reviews.llvm.org/D37804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia updated this revision to Diff 116548.
Anastasia added a comment.
Addressed comments from Alexey.
https://reviews.llvm.org/D37804
Files:
lib/CodeGen/CGBuilder.h
lib/CodeGen/CGExpr.cpp
test/CodeGenOpenCL/vectorLoadStore.cl
Index: test/CodeGenOpenCL/vectorLoadStore.cl
bader added inline comments.
Comment at: test/CodeGenOpenCL/vectorLoadStore.cl:7
+typedef float float4 __attribute((ext_vector_type(4)));
+;
Can we remove this line?
Comment at: test/CodeGenOpenCL/vectorLoadStore.cl:15
+
+// CHECK: define
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
https://reviews.llvm.org/D37804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Anastasia updated this revision to Diff 116345.
Anastasia added a comment.
Created BitCast or AddrSpaceCast conditionally.
https://reviews.llvm.org/D37804
Files:
lib/CodeGen/CGBuilder.h
lib/CodeGen/CGExpr.cpp
test/CodeGenOpenCL/vectorLoadStore.cl
Index:
yaxunl added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:957
-return Builder.CreateBitCast(Addr, ConvertType(E->getType()));
+return Builder.CreatePointerBitCastOrAddrSpaceCast(
+Addr, ConvertType(E->getType()));
Anastasia
Anastasia added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:957
-return Builder.CreateBitCast(Addr, ConvertType(E->getType()));
+return Builder.CreatePointerBitCastOrAddrSpaceCast(
+Addr, ConvertType(E->getType()));
Anastasia added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:957
-return Builder.CreateBitCast(Addr, ConvertType(E->getType()));
+return Builder.CreatePointerBitCastOrAddrSpaceCast(
+Addr, ConvertType(E->getType()));
yaxunl
yaxunl added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:957
-return Builder.CreateBitCast(Addr, ConvertType(E->getType()));
+return Builder.CreatePointerBitCastOrAddrSpaceCast(
+Addr, ConvertType(E->getType()));
Better
Anastasia created this revision.
Added missing `addrspacecast` case in alignment computation logic of pointer
type emission in IR generation.
https://reviews.llvm.org/D37804
Files:
lib/CodeGen/CGExpr.cpp
test/CodeGenOpenCL/vectorLoadStore.cl
Index: test/CodeGenOpenCL/vectorLoadStore.cl
14 matches
Mail list logo