This revision was automatically updated to reflect the committed changes.
Closed by commit rL313354: [clang-format] New flag -
BraceWrapping.AfterExternBlock (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D37845?vs=115240=115394#toc
Repository:
rL LLVM
PriMee added a comment.
I would be grateful, thank you!
https://reviews.llvm.org/D37845
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Looks good! Should I commit this for you?
https://reviews.llvm.org/D37845
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
PriMee updated this revision to Diff 115240.
PriMee added a comment.
Thank you for noticing! Done.
https://reviews.llvm.org/D37845
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/UnwrappedLineFormatter.cpp
krasimir added a comment.
Looks great! Just one more nit: please add a line checking the parsing of the
new option similar to the line `CHECK_PARSE_NESTED_BOOL(BraceWrapping,
AfterStruct);` in `unittests/Format/FormatTest.cpp`.
https://reviews.llvm.org/D37845
PriMee updated this revision to Diff 115202.
PriMee added a comment.
Sorry, forgot again...
https://reviews.llvm.org/D37845
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/UnwrappedLineFormatter.cpp
krasimir added inline comments.
Comment at: lib/Format/UnwrappedLineParser.cpp:1047
+else
+ parseBlock(/*MustBeDeclaration=*/true, /*AddLevel=*/false);
addUnwrappedLine();
Please `clang-format` the newly added lines.
