This revision was automatically updated to reflect the committed changes.
Closed by commit rC328619: [analyzer] LoopUnrolling: update the matched
assignment operators (authored by szepet, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D38921
Files:
szepet updated this revision to Diff 139776.
szepet added a comment.
Added the assignment operator matcher patch as a dependency and rebased on top
of that.
https://reviews.llvm.org/D38921
Files:
lib/StaticAnalyzer/Core/LoopUnrolling.cpp
test/Analysis/loop-unrolling.cpp
Index:
szepet marked 2 inline comments as done.
szepet added a comment.
In https://reviews.llvm.org/D38921#1037180, @alexfh wrote:
> Do you want to submit the matcher part separately?
Yepp, but added as a different patch since implemented it for cxxOperatorCall
as well. (I guess Aaron's test request
alexfh added a comment.
Do you want to submit the matcher part separately?
https://reviews.llvm.org/D38921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added a comment.
Aside from a request for another test, the matcher parts LGTM.
Comment at: unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp:1992
+ EXPECT_TRUE(matches("void x() { int a; a &= 3; }", AsOperator));
+ EXPECT_TRUE(notMatches("void x() { int a;
szepet added reviewers: alexfh, aaron.ballman.
szepet added a comment.
Added Alexander and Aaron as reviewers for the matcher parts.
https://reviews.llvm.org/D38921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
A nit, otherwise LG!
Comment at: lib/StaticAnalyzer/Core/PathDiagnostic.cpp:693
SMng);
+ } else if (Optional BE = P.getAs()) {
+S
szepet updated this revision to Diff 123187.
szepet marked 2 inline comments as done.
szepet added a comment.
Testfiles added and HTML updated.
https://reviews.llvm.org/D38921
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lebedev.ri added a comment.
Not sure how `clang/docs/LibASTMatchersReference.html` is supposed to be
updated.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:3931
+
+/// \brief Matches all kind of assignment operators.
+///
Maybe
```
-/// \brief Matches
szepet updated this revision to Diff 123176.
szepet added a reviewer: klimek.
szepet added a comment.
Herald added subscribers: a.sidorin, rnkovacs.
isAssignmentOp matcher moved to ASTMatchers.h
(Manuel added to reviewers as the code owner of ASTMatchers)
https://reviews.llvm.org/D38921
Files:
xazax.hun added a comment.
I agree it might be useful to expose this matcher to everybody.
https://reviews.llvm.org/D38921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ added a comment.
Yay.
Thanks Gabor, i didn't think about it but it look very nice to have such
matcher.
I think the matcher shouldn't be checker-local, but shared into `ASTMatchers.h`
all other matchers - not only this matcher is universally useful, but also i
have weird vague memories
szepet updated this revision to Diff 120732.
szepet added a comment.
Updated to use a custom AST matcher for assignment operator check. (More
structured and efficient.)
https://reviews.llvm.org/D38921
Files:
lib/StaticAnalyzer/Core/LoopUnrolling.cpp
test/Analysis/loop-unrolling.cpp
xazax.hun added inline comments.
Comment at: lib/StaticAnalyzer/Core/LoopUnrolling.cpp:100
declRefExpr(to(varDecl(VarNodeMatcher)),
binaryOperator(anyOf(hasOperatorName("="), hasOperatorName("+="),
NoQ added a comment.
Neat! Tests?
https://reviews.llvm.org/D38921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
danielmarjamaki added a comment.
LGTM.. however I would like approval from somebody else also.
https://reviews.llvm.org/D38921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
szepet created this revision.
Herald added subscribers: baloghadamsoftware, whisperity.
Extended the matched assignment operators when checking for bound changes in a
body of the loop. This updated list covers all the (current) possible
assignments.
https://reviews.llvm.org/D38921
Files:
17 matches
Mail list logo
