[PATCH] D40435: [clang-format] Deduplicate using declarations

2017-11-24 Thread Krasimir Georgiev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL318960: [clang-format] Deduplicate using declarations (authored by krasimir). Repository: rL LLVM https://reviews.llvm.org/D40435 Files: cfe/trunk/lib/Format/UsingDeclarationsSorter.cpp

[PATCH] D40435: [clang-format] Deduplicate using declarations

2017-11-24 Thread Benjamin Kramer via Phabricator via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D40435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40435: [clang-format] Deduplicate using declarations

2017-11-24 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir updated this revision to Diff 124215. krasimir added a comment. - Address review comments https://reviews.llvm.org/D40435 Files: lib/Format/UsingDeclarationsSorter.cpp unittests/Format/UsingDeclarationsSorterTest.cpp Index: unittests/Format/UsingDeclarationsSorterTest.cpp

[PATCH] D40435: [clang-format] Deduplicate using declarations

2017-11-24 Thread Benjamin Kramer via Phabricator via cfe-commits
bkramer added inline comments. Comment at: lib/Format/UsingDeclarationsSorter.cpp:115 +bool usingDeclarationsEqual(const UsingDeclaration , +const UsingDeclaration ) { I'd use a lambda instead. https://reviews.llvm.org/D40435