[PATCH] D41792: [AArch64] Add ARMv8.2-A FP16 scalar intrinsics

SjoerdMeijer closed this revision. SjoerdMeijer added a comment. Herald added a subscriber: hintonda. Committed as r323005 https://reviews.llvm.org/D41792 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41792: [AArch64] Add ARMv8.2-A FP16 scalar intrinsics

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D41792 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41792: [AArch64] Add ARMv8.2-A FP16 scalar intrinsics

az marked 6 inline comments as done. az added inline comments. Comment at: clang/include/clang/Basic/arm_fp16.td:58 +class IInst : Inst {} + +// ARMv8.2-A FP16 intrinsics. SjoerdMeijer wrote: > az wrote: > > SjoerdMeijer wrote: > > > There's a

[PATCH] D41792: [AArch64] Add ARMv8.2-A FP16 scalar intrinsics

az updated this revision to Diff 129513. az marked 3 inline comments as done. https://reviews.llvm.org/D41792 Files: clang/include/clang/Basic/BuiltinsNEON.def clang/include/clang/Basic/CMakeLists.txt clang/include/clang/Basic/arm_fp16.td clang/include/clang/Basic/arm_neon.td

[PATCH] D41792: [AArch64] Add ARMv8.2-A FP16 scalar intrinsics

SjoerdMeijer added inline comments. Comment at: clang/include/clang/Basic/arm_fp16.td:58 +class IInst : Inst {} + +// ARMv8.2-A FP16 intrinsics. az wrote: > SjoerdMeijer wrote: > > There's a little bit of duplication here: the definitions above

[PATCH] D41792: [AArch64] Add ARMv8.2-A FP16 scalar intrinsics

az marked 8 inline comments as done. az added inline comments. Comment at: clang/include/clang/Basic/arm_fp16.td:58 +class IInst : Inst {} + +// ARMv8.2-A FP16 intrinsics. SjoerdMeijer wrote: > There's a little bit of duplication here: the

[PATCH] D41792: [AArch64] Add ARMv8.2-A FP16 scalar intrinsics

az updated this revision to Diff 129360. https://reviews.llvm.org/D41792 Files: clang/include/clang/Basic/BuiltinsNEON.def clang/include/clang/Basic/CMakeLists.txt clang/include/clang/Basic/arm_fp16.td clang/include/clang/Basic/arm_neon.td clang/include/clang/Basic/arm_neon_incl.td

[PATCH] D41792: [AArch64] Add ARMv8.2-A FP16 scalar intrinsics

SjoerdMeijer added a comment. Thanks for working on this! Some comments inline. Comment at: clang/include/clang/Basic/arm_fp16.td:19 +// The operations are subclasses of Operation providing a list of DAGs, the +// last of which is the return value. +// nit:

[PATCH] D41792: [AArch64] Add ARMv8.2-A FP16 scalar intrinsics

az created this revision. az added a reviewer: SjoerdMeijer. Herald added subscribers: kristof.beyls, javed.absar, mgorny, rengolin, aemerson. ARMv8.2-A introduces half-precision floating point data processing. This patch adds the fp16 scalar intrinsics for this architecture as described in the