[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

This revision was automatically updated to reflect the committed changes. Closed by commit rL325410: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set (authored by vitalybuka, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

This revision was automatically updated to reflect the committed changes. Closed by commit rC325410: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set (authored by vitalybuka, committed by ). Changed prior to commit:

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

vitalybuka updated this revision to Diff 134752. vitalybuka marked an inline comment as done. vitalybuka added a comment. use count 0 https://reviews.llvm.org/D42680 Files: clang/include/clang/CodeGen/BackendUtil.h clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CodeGenAction.cpp

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/CodeGen/thinlto_backend.ll:27 +; RUN: %clang -target x86_64-unknown-linux-gnu -O2 -o %t4.o -x ir %t5.o -c -fthinlto-index=%t.thinlto.bc +; RUN:

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

vitalybuka added a comment. @pcc Could you please take a look? https://reviews.llvm.org/D42680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

vitalybuka updated this revision to Diff 133966. vitalybuka added a comment. fix rebase issues introduced in the last patch https://reviews.llvm.org/D42680 Files: clang/include/clang/CodeGen/BackendUtil.h clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CodeGenAction.cpp

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

vitalybuka added a comment. ping https://reviews.llvm.org/D42680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

vitalybuka updated this revision to Diff 133116. vitalybuka added a comment. set triple https://reviews.llvm.org/D42680 Files: clang/include/clang/CodeGen/BackendUtil.h clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CodeGenAction.cpp clang/test/CodeGen/thinlto_backend.ll Index:

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

vitalybuka updated this revision to Diff 133111. vitalybuka added a comment. Create valid empty object file https://reviews.llvm.org/D42680 Files: clang/include/clang/CodeGen/BackendUtil.h clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CodeGenAction.cpp

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

vitalybuka updated this revision to Diff 132876. vitalybuka marked 3 inline comments as done. vitalybuka added a comment. empty file test https://reviews.llvm.org/D42680 Files: clang/include/clang/CodeGen/BackendUtil.h clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CodeGenAction.cpp

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

tejohnson added a comment. This looks ok to me, assuming it produces the empty output file as I expect it should. Please wait for pcc to take a look as well. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:959 +if (!Bm) + return {}; Expected

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

vitalybuka added a comment. PTAL https://reviews.llvm.org/D42680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

vitalybuka updated this revision to Diff 132702. vitalybuka marked an inline comment as done. vitalybuka added a comment. comment https://reviews.llvm.org/D42680 Files: clang/include/clang/CodeGen/BackendUtil.h clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CodeGenAction.cpp