This revision was automatically updated to reflect the committed changes.
Closed by commit rL326102: [DebugInfo] Support DWARF v5 source code embedding
extension (authored by scott.linder, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D42766
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
scott.linder updated this revision to Diff 135909.
scott.linder added a comment.
New diff addresses feedback. I committed the refactoring as NFC and rebased,
then clarified the extension comment.
https://reviews.llvm.org/D42766
Files:
docs/ClangCommandLineReference.rst
include/clang/Driver
probinson added a comment.
Looks generally straightforward. I'd give other people a chance to chime in
but I have only minor comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:411
// If the location is not valid then use main input file.
-return DBuilder.createFile(re
scott.linder added a comment.
With https://reviews.llvm.org/D42765 committed I think this is ready for review.
Repository:
rC Clang
https://reviews.llvm.org/D42766
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
scott.linder created this revision.
scott.linder added reviewers: echristo, arsenm, aprantl.
Herald added subscribers: cfe-commits, JDevlieghere, nhaehnle, wdng.
In DWARFv5 the Line Number Program Header is extensible, allowing values
with new content types. In this extension source is embedded di
