[PATCH] D42810: [Sema] Add implicit members even for invalid CXXRecordDecls

2018-02-02 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC324062: [Sema] Add implicit members even for invalid CXXRecordDecls (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D42810?vs=132443=132546#toc Repository:

[PATCH] D42810: [Sema] Add implicit members even for invalid CXXRecordDecls

2018-02-01 Thread Benjamin Kramer via Phabricator via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D42810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42810: [Sema] Add implicit members even for invalid CXXRecordDecls

2018-02-01 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. The following assertion from `DeclContext::removeDecl` was failing before: assert((D->NextInContextAndBits.getPointer() || D == LastDecl) && "decl is not in decls list"); Repository: rC Clang https://reviews.llvm.org/D42810

[PATCH] D42810: [Sema] Add implicit members even for invalid CXXRecordDecls

2018-02-01 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov created this revision. ilya-biryukov added a reviewer: bkramer. It should be safe, since other code paths are already generating implicit members even in invalid CXXRecordDecls (e.g. lookup). If we don't generate implicit members on CXXRecordDecl's completion, they will be