[PATCH] D42978: Make march/target-cpu print a note with the list of valid values for ARM

simpal01 added a comment. @erichkeane Could you please tell me why this was done only for -cc1 and if there is any plan to add this to the driver in general ? Repository: rL LLVM https://reviews.llvm.org/D42978 ___ cfe-commits mailing list

[PATCH] D42978: Make march/target-cpu print a note with the list of valid values for ARM

This revision was automatically updated to reflect the committed changes. Closed by commit rL324673: Make march/target-cpu print a note with the list of valid values for ARM (authored by erichkeane, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D42978: Make march/target-cpu print a note with the list of valid values for ARM

erichkeane updated this revision to Diff 133452. erichkeane added a comment. Relaxed the test further. https://reviews.llvm.org/D42978 Files: include/clang/Basic/DiagnosticCommonKinds.td include/clang/Basic/TargetInfo.h lib/Basic/Targets.cpp lib/Basic/Targets/AArch64.cpp

[PATCH] D42978: Make march/target-cpu print a note with the list of valid values for ARM

erichkeane added inline comments. Comment at: test/Misc/target-invalid-cpu-note.c:1 +// RUN: not %clang_cc1 -triple armv5--- -target-cpu not-a-cpu -fsyntax-only %s 2>&1 | FileCheck %s --check-prefix ARM +// ARM: error: unknown target CPU 'not-a-cpu' erichkeane

[PATCH] D42978: Make march/target-cpu print a note with the list of valid values for ARM

erichkeane added inline comments. Comment at: test/Misc/target-invalid-cpu-note.c:1 +// RUN: not %clang_cc1 -triple armv5--- -target-cpu not-a-cpu -fsyntax-only %s 2>&1 | FileCheck %s --check-prefix ARM +// ARM: error: unknown target CPU 'not-a-cpu' Hahnfeld

[PATCH] D42978: Make march/target-cpu print a note with the list of valid values for ARM

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM thanks. Please wait a day or so with committing so others can raise additional concerns. Comment at: test/Misc/target-invalid-cpu-note.c:8 +// AARCH64: note: valid

[PATCH] D42978: Make march/target-cpu print a note with the list of valid values for ARM

Hahnfeld added inline comments. Comment at: test/Misc/target-invalid-cpu-note.c:1 +// RUN: not %clang_cc1 -triple armv5--- -target-cpu not-a-cpu -fsyntax-only %s 2>&1 | FileCheck %s --check-prefix ARM +// ARM: error: unknown target CPU 'not-a-cpu' Is there a

[PATCH] D42978: Make march/target-cpu print a note with the list of valid values for ARM

erichkeane updated this revision to Diff 133442. erichkeane marked an inline comment as done. erichkeane added a comment. Removed extra newline. https://reviews.llvm.org/D42978 Files: include/clang/Basic/DiagnosticCommonKinds.td include/clang/Basic/TargetInfo.h lib/Basic/Targets.cpp

[PATCH] D42978: Make march/target-cpu print a note with the list of valid values for ARM

erichkeane added a comment. That makes sense. I changed the ARM one to check ONLY the first one, since in each case that seems like the oldest anyway. It at least makes sure that the lists are distinct, and avoids this cross-repo fragility. https://reviews.llvm.org/D42978

[PATCH] D42978: Make march/target-cpu print a note with the list of valid values for ARM

erichkeane updated this revision to Diff 133435. erichkeane added a comment. Simplified ARM tests as requested. https://reviews.llvm.org/D42978 Files: include/clang/Basic/DiagnosticCommonKinds.td include/clang/Basic/TargetInfo.h lib/Basic/Targets.cpp lib/Basic/Targets/AArch64.cpp

[PATCH] D42978: Make march/target-cpu print a note with the list of valid values for ARM

fhahn added a comment. In https://reviews.llvm.org/D42978#1001616, @Hahnfeld wrote: > I think this means that the Clang test needs to be updated whenever somebody > adds an architecture to LLVM? Maybe just test that Clang emits a note and > don't check which values it prints? These should be

[PATCH] D42978: Make march/target-cpu print a note with the list of valid values for ARM

Hahnfeld added a comment. I think this means that the Clang test needs to be updated whenever somebody adds an architecture to LLVM? Maybe just test that Clang emits a note and don't check which values it prints? These should be checked in the backend... https://reviews.llvm.org/D42978

[PATCH] D42978: Make march/target-cpu print a note with the list of valid values for ARM

erichkeane updated this revision to Diff 133276. erichkeane retitled this revision from "Make march/target-cpu print a note with the list of valid values" to "Make march/target-cpu print a note with the list of valid values for ARM". erichkeane edited the summary of this revision.