[PATCH] D43153: [clang] Implement P0692 "Access Checking on Specializations"

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D43153: [clang] Implement P0692 "Access Checking on Specializations"

rsmith added a comment. In https://reviews.llvm.org/D43153#1004464, @AntonBikineev wrote: > So is my impression wrong and names in declaration-specifiers/declarators of > partial-specialiations of variable-templates should be exempted from checks > as well? No, sorry, that's my error not

[PATCH] D43153: [clang] Implement P0692 "Access Checking on Specializations"

AntonBikineev added a comment. @rsmith Thanks for pointing out this example. Now I see that I misunderstood the wording. Another question is that in the provided example you say that the following line template A::B x; // ok! should suppress the error of accessing private A::B. But in

[PATCH] D43153: [clang] Implement P0692 "Access Checking on Specializations"

rsmith added a comment. How do you avoid suppressing diagnostics in the declaration of a template that is not a partial specialization? For example: class A { class B {}; }; template A::B x; // error, but... template A::B x; // ok! I would expect you'd need to delay the access

[PATCH] D43153: [clang] Implement P0692 "Access Checking on Specializations"

AntonBikineev created this revision. AntonBikineev added reviewers: rsmith, lebedev.ri. This is an attempt to implement P0692 Please note a couple of things: 1. given that clang already suppresses access checks on explicit