This revision was automatically updated to reflect the committed changes.
Closed by commit rC324995: [clang-format] Support text proto extensions
(authored by krasimir, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43180?vs=133872=134013#toc
Repository:
rC Clang
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Cool, thanks.
Repository:
rC Clang
https://reviews.llvm.org/D43180
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
krasimir marked an inline comment as done.
krasimir added inline comments.
Comment at: unittests/Format/FormatTestTextProto.cpp:317
+
+TEST_F(FormatTestTextProto, FormatsExtensions) {
+ verifyFormat("[type] { key: value }");
djasper wrote:
> It might be useful
krasimir updated this revision to Diff 133872.
krasimir added a comment.
- Add tests with long [...]
Repository:
rC Clang
https://reviews.llvm.org/D43180
Files:
lib/Format/ContinuationIndenter.cpp
lib/Format/FormatToken.h
lib/Format/TokenAnnotator.cpp
djasper added inline comments.
Comment at: unittests/Format/FormatTestTextProto.cpp:317
+
+TEST_F(FormatTestTextProto, FormatsExtensions) {
+ verifyFormat("[type] { key: value }");
It might be useful to attach a test case for what happens if the "[...]" does
krasimir created this revision.
Herald added subscribers: cfe-commits, klimek.
This adds support for text proto extensions, like:
msg {
[type.type/ext] {
key: value
}
}
Repository:
rC Clang
https://reviews.llvm.org/D43180
Files:
lib/Format/ContinuationIndenter.cpp
