[PATCH] D43248: [Attr] Fix printing of parameter indices in attributes

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:182 + // it would always be false. + string DisallowImplicitThisParamName = disallowImplicitThisParamName; +} jdenny wrote: > aaron.ballman wrote: > > jdenny wrote: > > > aaron.ballman

[PATCH] D43248: [Attr] Fix printing of parameter indices in attributes

jdenny added inline comments. Comment at: include/clang/Basic/Attr.td:182 + // it would always be false. + string DisallowImplicitThisParamName = disallowImplicitThisParamName; +} aaron.ballman wrote: > jdenny wrote: > > aaron.ballman wrote: > > > jdenny wrote:

[PATCH] D43248: [Attr] Fix printing of parameter indices in attributes

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:182 + // it would always be false. + string DisallowImplicitThisParamName = disallowImplicitThisParamName; +} jdenny wrote: > aaron.ballman wrote: > > jdenny wrote: > > > jdenny wrote:

[PATCH] D43248: [Attr] Fix printing of parameter indices in attributes

jdenny added inline comments. Comment at: include/clang/Basic/Attr.td:182 + // it would always be false. + string DisallowImplicitThisParamName = disallowImplicitThisParamName; +} aaron.ballman wrote: > jdenny wrote: > > jdenny wrote: > > > aaron.ballman wrote:

[PATCH] D43248: [Attr] Fix printing of parameter indices in attributes

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:182 + // it would always be false. + string DisallowImplicitThisParamName = disallowImplicitThisParamName; +} jdenny wrote: > jdenny wrote: > > aaron.ballman wrote: > > > Is there much

[PATCH] D43248: [Attr] Fix printing of parameter indices in attributes

jdenny marked 3 inline comments as done. jdenny added a comment. Comment at: include/clang/Basic/Attr.td:182 + // it would always be false. + string DisallowImplicitThisParamName = disallowImplicitThisParamName; +} jdenny wrote: > aaron.ballman wrote: > > Is

[PATCH] D43248: [Attr] Fix printing of parameter indices in attributes

aaron.ballman added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:355-357 } + else if (DisallowImplicitThisParam) +*DisallowImplicitThisParam = false; jdenny wrote: > aaron.ballman wrote: > > Formatting is off here -- the `else if` should go up a

[PATCH] D43248: [Attr] Fix printing of parameter indices in attributes

jdenny added inline comments. Comment at: include/clang/Basic/Attr.td:182 + // it would always be false. + string DisallowImplicitThisParamName = disallowImplicitThisParamName; +} aaron.ballman wrote: > Is there much benefit to forcing the attribute author to p

[PATCH] D43248: [Attr] Fix printing of parameter indices in attributes

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:182 + // it would always be false. + string DisallowImplicitThisParamName = disallowImplicitThisParamName; +} Is there much benefit to forcing the attribute author to pick a name for t

[PATCH] D43248: [Attr] Fix printing of parameter indices in attributes

jdenny created this revision. jdenny added reviewers: aaron.ballman, hfinkel. Parameter indices in some attributes (argument_with_type_tag, pointer_with_type_tag, nonnull, ownership_takes, ownership_holds, and ownership_returns) are specified in source as one-origin including any this parameter,