[PATCH] D43312: [clang-format] fix handling of consecutive unary operators

2018-03-06 Thread Krasimir Georgiev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL326792: [clang-format] fix handling of consecutive unary operators (authored by krasimir, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D4331

[PATCH] D43312: [clang-format] fix handling of consecutive unary operators

2018-02-26 Thread Kevin Lee via Phabricator via cfe-commits
kevinl added a comment. @krasimir ping? would appreciate you committing this for me. thanks! Repository: rC Clang https://reviews.llvm.org/D43312 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D43312: [clang-format] fix handling of consecutive unary operators

2018-02-16 Thread Kevin Lee via Phabricator via cfe-commits
kevinl added a comment. I do not have commit access. Would appreciate you committing it for me. Thanks! Repository: rC Clang https://reviews.llvm.org/D43312 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D43312: [clang-format] fix handling of consecutive unary operators

2018-02-16 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you! Do you have commit access or should I commit this for you? Repository: rC Clang https://reviews.llvm.org/D43312 ___ cfe-commits

[PATCH] D43312: [clang-format] fix handling of consecutive unary operators

2018-02-15 Thread Kevin Lee via Phabricator via cfe-commits
kevinl added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:1497 +!(PrevToken->is(tok::exclaim) && + Style.Language == FormatStyle::LK_JavaScript)) // There aren't any trailing unary operators except for TypeScript's krasimir w

[PATCH] D43312: [clang-format] fix handling of consecutive unary operators

2018-02-15 Thread Kevin Lee via Phabricator via cfe-commits
kevinl updated this revision to Diff 134511. kevinl edited the summary of this revision. kevinl added a comment. Simplified the heuristic logic, which extends the fix to TypeScript as well Repository: rC Clang https://reviews.llvm.org/D43312 Files: lib/Format/TokenAnnotator.cpp unittests

[PATCH] D43312: [clang-format] fix handling of consecutive unary operators

2018-02-15 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:1497 +!(PrevToken->is(tok::exclaim) && + Style.Language == FormatStyle::LK_JavaScript)) // There aren't any trailing unary operators except for TypeScript's I think

[PATCH] D43312: [clang-format] fix handling of consecutive unary operators

2018-02-14 Thread Kevin Lee via Phabricator via cfe-commits
kevinl created this revision. kevinl added a reviewer: djasper. Herald added subscribers: cfe-commits, klimek. C++ code that used to be formatted as `if (! + object) {` is now formatted as `if (!+object) {` (we have a particular object in our codebase where unary `operator+` is overloaded to ret