[PATCH] D43362: Simplify setting dso_local. NFC.

2018-02-22 Thread Rafael Avila de Espindola via Phabricator via cfe-commits
espindola closed this revision. espindola added a comment. r325846 https://reviews.llvm.org/D43362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43362: Simplify setting dso_local. NFC.

2018-02-22 Thread Eric Christopher via Phabricator via cfe-commits
echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the cleanup. https://reviews.llvm.org/D43362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

Re: [PATCH] D43362: Simplify setting dso_local. NFC.

2018-02-20 Thread Rafael Avila de Espindola via cfe-commits
ping Rafael Avila de Espindola via Phabricator writes: > espindola created this revision. > espindola added a reviewer: rnk. > > The value of dso_local can be computed from just IR properties and global > information (object file type, command line options, etc). > > With this patch we no longe

[PATCH] D43362: Simplify setting dso_local. NFC.

2018-02-15 Thread Rafael Avila de Espindola via Phabricator via cfe-commits
espindola created this revision. espindola added a reviewer: rnk. The value of dso_local can be computed from just IR properties and global information (object file type, command line options, etc). With this patch we no longer pass in the Decl. It was almost unused and making it fully unused g