[PATCH] D43454: [clangd] Do not reuse preamble if compile args changed

2018-02-19 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL325522: [clangd] Do not reuse preamble if compile args changed (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D43454: [clangd] Do not reuse preamble if compile args changed

2018-02-19 Thread Simon Marchi via Phabricator via cfe-commits
simark accepted this revision. simark added a comment. This revision is now accepted and ready to land. I don't have the setup to test at the moment, but the code looks good to me. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43454

[PATCH] D43454: [clangd] Do not reuse preamble if compile args changed

2018-02-19 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov created this revision. ilya-biryukov added reviewers: hokein, ioeric, sammccall. Herald added subscribers: cfe-commits, jkorous-apple, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43454 Files: clangd/ClangdUnit.cpp clangd/ClangdUnit.h