SjoerdMeijer added a comment.
FYI: I have partially recommitted this in r327455; I have separated out the
minimal functional change related to the FP16 macros.
https://reviews.llvm.org/D43650
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
SjoerdMeijer added a comment.
Reverted in r327437.
https://reviews.llvm.org/D43650
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
SjoerdMeijer added a comment.
Hi @mstorsjo, thanks for reporting this!
I was waiting for @az, and only had a quick look myself, but I don't think it's
going to be
a quick fix. So that would suggest indeed that a revert is a best. Perhaps we
can wait a few
more hours to give the guys in the US ti
mstorsjo added a comment.
In https://reviews.llvm.org/D43650#1034009, @mstorsjo wrote:
> This change broke building Qt for armv7, see PR36683 for details.
Ping - any update on looking into this? Should we revert this change for now,
until the breakage is handled?
https://reviews.llvm.org/D43
mstorsjo added a comment.
This change broke building Qt for armv7, see PR36683 for details.
https://reviews.llvm.org/D43650
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.
Look like sensible cleanups/fixes/additions to me.
We were struggling whether to pass an i16 or f16 type, which can both be
illegal types.
Therefore, it perhaps doesn't really matt
az created this revision.
az added a reviewer: SjoerdMeijer.
Herald added subscribers: kristof.beyls, javed.absar.
This patch adds the fp16 neon vector intrinsic for ARM as described in the ARM
ACLE document.
While this patch may seem large at first but it is essentially a
modification/addition