This revision was automatically updated to reflect the committed changes.
Closed by commit rL326051: [clangd] Address FIXME and fix comment (authored by
omtcyfz, committed by ).
Herald added subscribers: llvm-commits, klimek.
Changed prior to commit:
omtcyfz updated this revision to Diff 135815.
omtcyfz marked an inline comment as done.
omtcyfz added a comment.
Address Eric's nit: make warning message shorter so that it would fit into one
line in order to omit braces for a single statement for compliance with the
clang-tools-extra
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Oops, just realized I forgot to push the "send" button!
Comment at: clangd/tool/ClangdMain.cpp:153
+ if (RunSynchronously) {
+if
omtcyfz marked an inline comment as done.
omtcyfz added inline comments.
Comment at: clangd/tool/ClangdMain.cpp:153
+ if (RunSynchronously) {
+if (WorkerThreadsCount != 0) {
+ llvm::errs()
ioeric wrote:
> `-j` is non-zero by default, and we shouldn't
omtcyfz updated this revision to Diff 135626.
omtcyfz added a comment.
Addressed review comment by actually checking whether -j option was actually
passed to clangd.
https://reviews.llvm.org/D43671
Files:
clangd/Context.cpp
clangd/tool/ClangdMain.cpp
Index: clangd/tool/ClangdMain.cpp
ioeric added a comment.
Thanks for the cleanup Kirill :)
Comment at: clangd/tool/ClangdMain.cpp:153
+ if (RunSynchronously) {
+if (WorkerThreadsCount != 0) {
+ llvm::errs()
`-j` is non-zero by default, and we shouldn't show warning if users only
omtcyfz created this revision.
omtcyfz added a reviewer: ioeric.
omtcyfz added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, jkorous-apple, ilya-biryukov.
- Address a FIXME by warning the user that both -run-synchronously and -j X are
passed.
- Fix a comment to suppress
