This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL327598: Refactoring code around move/copy initialization.
NFC. (authored by rtrieu, committed by ).
Herald added a subscr
Quuxplusone added a comment.
@rtrieu thanks! I don't have commit privileges; could I ask you to commit this
on my behalf? (Or if not, please say no, and I'll know to go looking for
someone else to ask.)
Once/if https://reviews.llvm.org/D43898 hits master, I'll rebase
https://reviews.llvm.org
rtrieu added a comment.
Everything looks good and ready for commit.
Repository:
rC Clang
https://reviews.llvm.org/D43898
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Quuxplusone updated this revision to Diff 137920.
Quuxplusone marked an inline comment as done.
Quuxplusone added a comment.
Addressed @rtrieu's comments.
@rtrieu, please take another look at this and https://reviews.llvm.org/D43322?
Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D43
Quuxplusone marked 4 inline comments as done.
Quuxplusone added inline comments.
Comment at: lib/Sema/SemaStmt.cpp:2970
+ FunctionDecl *FD = Step.Function.Function;
+ if (isa(FD)) {
+// C++14 [class.copy]p32:
rtrieu wrote:
> Use early exit here:
rtrieu added inline comments.
Comment at: lib/Sema/SemaStmt.cpp:2953
+ ExprResult &Res)
+{
+ ImplicitCastExpr AsRvalue(ImplicitCastExpr::OnStack, Value->getType(),
Opening brace should follow the closing paren on previous line.
Quuxplusone added a comment.
@rtrieu ping?
Repository:
rC Clang
https://reviews.llvm.org/D43898
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Quuxplusone added a comment.
@rtrieu please take a look?
Also, I would need someone to commit this for me, as I don't have commit privs.
Repository:
rC Clang
https://reviews.llvm.org/D43898
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Quuxplusone updated this revision to Diff 136380.
Quuxplusone added a comment.
Add a block comment for function `TryMoveInitialization`.
Repository:
rC Clang
https://reviews.llvm.org/D43898
Files:
include/clang/Sema/Sema.h
lib/Sema/SemaExprCXX.cpp
lib/Sema/SemaStmt.cpp
lib/Sema/SemaT
Quuxplusone created this revision.
Quuxplusone added a reviewer: rtrieu.
Herald added a subscriber: cfe-commits.
This patch is extracted from https://reviews.llvm.org/D43322, which adds a new
diagnostic `-Wreturn-std-move`. This patch here is just the non-functional
parts of that patch. It pulls
10 matches
Mail list logo
