This revision was automatically updated to reflect the committed changes.
Closed by commit rL326476: [RecordLayout] Only assert that fundamental type
sizes are power of two on MSVC (authored by mstorsjo, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
compnerd accepted this revision.
compnerd added a comment.
Awesome, thanks, this makes me feel much more comfortable.
https://reviews.llvm.org/D43908
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
mstorsjo updated this revision to Diff 136471.
mstorsjo edited the summary of this revision.
mstorsjo added a comment.
Added an error-by-default diagnostic (just like the existing
warn_cxx_ms_struct) for this case, trigger it on all targets other than mingw
(where the situation is quite likely
compnerd accepted this revision.
compnerd added a comment.
Ugh, really not a fan of this change.
Repository:
rC Clang
https://reviews.llvm.org/D43908
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D43908
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
mstorsjo created this revision.
mstorsjo added reviewers: efriedma, compnerd.
This fixes using the ms_struct attribute together with long double on e.g.
x86-32 linux.
Repository:
rC Clang
https://reviews.llvm.org/D43908
Files:
lib/AST/RecordLayoutBuilder.cpp
