[PATCH] D44188: Misc typos

[Alexander Kornienko via Phabricator via cfe-commits]

alexfh added a comment.

Feel free to send the rest of the fixes as a separate patch.


Repository:
  rL LLVM

https://reviews.llvm.org/D44188



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44188: Misc typos

[Alexander Kornienko via Phabricator via cfe-commits]

alexfh accepted this revision.
alexfh added a comment.

Thanks!
I've looked through all the fixes. Most of them look reasonable. I've reverted 
a few files where I found something suspicious or outright wrong and will 
commit the rest of the patch after I ensure the tests pass.

These files couldn't be patched:

  include/clang/Basic/AttrDocs.td
  lib/Basic/VirtualFileSystem.cpp
  lib/CodeGen/CGExpr.cpp
  lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
  lib/Driver/ToolChains/Hexagon.cpp
  lib/Sema/Sema.cpp
  lib/StaticAnalyzer/Core/CoreEngine.cpp
  test/CodeGenCXX/ms-integer-static-data-members.cpp

The list of the files I reverted:

  lib/ARCMigrate/FileRemapper.cpp
  lib/AST/ExprConstant.cpp
  lib/Frontend/CacheTokens.cpp
  lib/Frontend/CompilerInvocation.cpp
  lib/Headers/htmintrin.h
  lib/Parse/Parser.cpp
  lib/Sema/SemaDeclCXX.cpp
  lib/Sema/SemaLookup.cpp
  test/CodeGen/builtins-arm-exclusive.c
  test/CodeGen/vectorcall.c
  test/Modules/odr_hash.cpp
  test/Sema/warn-documentation-fixits.cpp
  test/Sema/warn-documentation-unknown-command.cpp


Repository:
  rC Clang

https://reviews.llvm.org/D44188



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44188: Misc typos

[Artem Belevich via Phabricator via cfe-commits]

tra added a comment.

You may want to split the patch into smaller pieces -- per leaf directory, for 
example. 
That way potential reviewers would at least be able to see the changes 
(hundreds of files in one patch is a bit too much), and the subset of changes 
would be small enough for someone to own it (or at least familiar enough with 
it to give approval).


Repository:
  rC Clang

https://reviews.llvm.org/D44188



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44188: Misc typos

[luzpaz via Phabricator via cfe-commits]

luzpaz added a comment.

Please advise how to proceed


Repository:
  rC Clang

https://reviews.llvm.org/D44188



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits