rnk added a comment.
Should be fixed in https://reviews.llvm.org/rL327754.
Repository:
rC Clang
https://reviews.llvm.org/D44505
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk added a comment.
And, this appears to have broken clang's self-host:
http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/10799
Time to debug.
Repository:
rC Clang
https://reviews.llvm.org/D44505
___
cfe-commits mailing list
rnk added a comment.
Thanks! I'm sorry I wasn't able to express these ideas better in
https://reviews.llvm.org/D39063.
Repository:
rC Clang
https://reviews.llvm.org/D44505
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rC327732: [MS] Always use base dtors in place of
complete/vbase dtors when possible (authored by rnk, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D44505?vs=138485=138748#toc
zahiraam added a comment.
LGTM 2. It fixes PR32990.
https://reviews.llvm.org/D44505
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D44505
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rnk created this revision.
rnk added reviewers: erichkeane, zahiraam, majnemer, rjmccall.
Previously we tried too hard to uphold the fiction that destructor
variants work like they do on Itanium throughout the ABI-neutral parts
of clang. This lead to MS C++ ABI incompatiblities and other bugs.
