This revision was automatically updated to reflect the committed changes.
Closed by commit rL328807: [Sema] Make deprecation fix-it replace all
multi-parameter ObjC method slots. (authored by vsapsai, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
This revision was automatically updated to reflect the committed changes.
Closed by commit rC328807: [Sema] Make deprecation fix-it replace all
multi-parameter ObjC method slots. (authored by vsapsai, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D44589?vs=139981=140287#toc
vsapsai updated this revision to Diff 139981.
vsapsai added a comment.
- More tweaks. Remove MultiSourceLocation as nobobody, including me, sees much
value in it.
https://reviews.llvm.org/D44589
Files:
clang/include/clang/Basic/CharInfo.h
clang/include/clang/Sema/DelayedDiagnostic.h
erik.pilkington accepted this revision.
erik.pilkington added a comment.
This revision is now accepted and ready to land.
LGTM, this is a really nice feature!
Comment at: clang/include/clang/Basic/SourceLocation.h:202
+/// Can be used transparently in places where
vsapsai marked 2 inline comments as done.
vsapsai added inline comments.
Comment at: clang/include/clang/Basic/SourceLocation.h:202
+/// Can be used transparently in places where SourceLocation is expected.
+class MultiSourceLocation {
+ bool IsSingleLoc;
vsapsai updated this revision to Diff 139650.
vsapsai added a comment.
Address review comments:
- update comments for tryParseObjCMethodName, use isValidIdentifier.
- make MultiSourceLocation more lightweight.
I have rebased my patch, so diff between changes can be noisy.
erik.pilkington added a comment.
Hi Volodymyr, thanks for working on this! Overall this looks good, I just have
a few nits.
Comment at: clang/include/clang/Basic/SourceLocation.h:202
+/// Can be used transparently in places where SourceLocation is expected.
+class
vsapsai added a comment.
In https://reviews.llvm.org/D44589#1044350, @aaron.ballman wrote:
> This generally looks reasonable to me, but @rsmith should weigh in before you
> commit because `MultiSourceLocation` is novel.
Thanks for the review, Aaron. I tried not to do anything stupid with
aaron.ballman added a comment.
This generally looks reasonable to me, but @rsmith should weigh in before you
commit because `MultiSourceLocation` is novel.
https://reviews.llvm.org/D44589
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
vsapsai marked 3 inline comments as done.
vsapsai added inline comments.
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7207-7217
+} else {
+ FixIts.push_back(FixItHint::CreateInsertion(
+ SelectorLocs[I], SelectorSlotNames[I]));
+
vsapsai updated this revision to Diff 139233.
vsapsai added a comment.
Address review comments:
- Replace `auto` with explicit type.
- Use `llvm::makeArrayRef`.
- Remove curly braces around single-statement elses.
https://reviews.llvm.org/D44589
Files:
aaron.ballman added inline comments.
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7207-7217
+} else {
+ FixIts.push_back(FixItHint::CreateInsertion(
+ SelectorLocs[I], SelectorSlotNames[I]));
+}
+ }
+} else {
vsapsai added inline comments.
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7207-7217
+} else {
+ FixIts.push_back(FixItHint::CreateInsertion(
+ SelectorLocs[I], SelectorSlotNames[I]));
+}
+ }
+} else {
+
aaron.ballman added a reviewer: rsmith.
aaron.ballman added inline comments.
Comment at: clang/include/clang/Sema/DelayedDiagnostic.h:198-199
+assert(Kind == Availability && "Not an availability diagnostic.");
+return MultiSourceLocation(ArrayRef(
+
vsapsai created this revision.
vsapsai added reviewers: aaron.ballman, erik.pilkington.
Herald added a subscriber: jkorous-apple.
Deprecation replacement can be any text but if it looks like a name of
ObjC method and has the same number of arguments as original method,
replace all slot names so
15 matches
Mail list logo
