[PATCH] D44773: [CMake] Use custom command and target to install libc++ headers

This revision was automatically updated to reflect the committed changes. Closed by commit rCXX329544: [CMake] Use custom command and target to install libc++ headers (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D44773?vs=141580=141583#toc Repository:

[PATCH] D44773: [CMake] Use custom command and target to install libc++ headers

This revision was automatically updated to reflect the committed changes. Closed by commit rL329544: [CMake] Use custom command and target to install libc++ headers (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D44773: [CMake] Use custom command and target to install libc++ headers

phosek updated this revision to Diff 141580. Repository: rCXX libc++ https://reviews.llvm.org/D44773 Files: libcxx/NOTES.TXT libcxx/cmake/Modules/HandleLibCXXABI.cmake libcxx/include/CMakeLists.txt libcxx/lib/CMakeLists.txt Index: libcxx/lib/CMakeLists.txt

[PATCH] D44773: [CMake] Use custom command and target to install libc++ headers

EricWF added a comment. There are a couple of new headers, `` and `` that should be added to the list before committing. Repository: rCXX libc++ https://reviews.llvm.org/D44773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44773: [CMake] Use custom command and target to install libc++ headers

phosek updated this revision to Diff 141442. phosek marked an inline comment as done. Repository: rCXX libc++ https://reviews.llvm.org/D44773 Files: libcxx/NOTES.TXT libcxx/cmake/Modules/HandleLibCXXABI.cmake libcxx/include/CMakeLists.txt libcxx/lib/CMakeLists.txt Index:

[PATCH] D44773: [CMake] Use custom command and target to install libc++ headers

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. This LGTM modulo requested changes. There's a section in `NOTES.TXT` about the steps required for adding a header. Please update that to mention listing it in CMake.

[PATCH] D44773: [CMake] Use custom command and target to install libc++ headers

phosek added a comment. ping Repository: rCXX libc++ https://reviews.llvm.org/D44773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44773: [CMake] Use custom command and target to install libc++ headers

phosek added a comment. This changes has already revealed some missing libc++ dependencies in sanitizers which were masked by the use of `file(COPY FILE...)`. Repository: rCXX libc++ https://reviews.llvm.org/D44773 ___ cfe-commits mailing list

[PATCH] D44773: [CMake] Use custom command and target to install libc++ headers

phosek created this revision. phosek added reviewers: EricWF, beanz. Herald added subscribers: cfe-commits, christof, fedor.sergeev, mgorny, srhines. Using file(COPY FILE...) has several downsides. Since the file command is only executed at configuration time, any changes to headers made after