[PATCH] D45285: [clangd-vscode] Update VScode dependencies

[Marc-Andre Laperle via Phabricator via cfe-commits]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE329574: [clangd-vscode] Update VScode dependencies 
(authored by malaperle, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D45285?vs=141036=141645#toc

Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D45285

Files:
  clangd/clients/clangd-vscode/package.json


Index: clangd/clients/clangd-vscode/package.json
===
--- clangd/clients/clangd-vscode/package.json
+++ clangd/clients/clangd-vscode/package.json
@@ -6,7 +6,7 @@
 "publisher": "llvm-vs-code-extensions",
 "homepage": "https://clang.llvm.org/extra/clangd.html;,
 "engines": {
-"vscode": "^1.15.0"
+"vscode": "^1.18.0"
 },
 "categories": [
 "Languages",
@@ -32,12 +32,12 @@
 "test": "node ./node_modules/vscode/bin/test"
 },
 "dependencies": {
-"vscode-languageclient": "^3.3.0",
-"vscode-languageserver": "^3.3.0"
+"vscode-languageclient": "^4.0.0",
+"vscode-languageserver": "^4.0.0"
 },
 "devDependencies": {
 "typescript": "^2.0.3",
-"vscode": "^1.0.3",
+"vscode": "^1.1.0",
 "mocha": "^2.3.3",
 "@types/node": "^6.0.40",
 "@types/mocha": "^2.2.32"


Index: clangd/clients/clangd-vscode/package.json
===
--- clangd/clients/clangd-vscode/package.json
+++ clangd/clients/clangd-vscode/package.json
@@ -6,7 +6,7 @@
 "publisher": "llvm-vs-code-extensions",
 "homepage": "https://clang.llvm.org/extra/clangd.html;,
 "engines": {
-"vscode": "^1.15.0"
+"vscode": "^1.18.0"
 },
 "categories": [
 "Languages",
@@ -32,12 +32,12 @@
 "test": "node ./node_modules/vscode/bin/test"
 },
 "dependencies": {
-"vscode-languageclient": "^3.3.0",
-"vscode-languageserver": "^3.3.0"
+"vscode-languageclient": "^4.0.0",
+"vscode-languageserver": "^4.0.0"
 },
 "devDependencies": {
 "typescript": "^2.0.3",
-"vscode": "^1.0.3",
+"vscode": "^1.1.0",
 "mocha": "^2.3.3",
 "@types/node": "^6.0.40",
 "@types/mocha": "^2.2.32"
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45285: [clangd-vscode] Update VScode dependencies

[Marc-Andre Laperle via Phabricator via cfe-commits]

malaperle added a comment.

In https://reviews.llvm.org/D45285#1061374, @hokein wrote:

> In https://reviews.llvm.org/D45285#1061243, @ilya-biryukov wrote:
>
> > In https://reviews.llvm.org/D45285#1058567, @malaperle wrote:
> >
> > > Do we need to bump the version of the extension and do a new release or 
> > > anything like that? Or leave this for later?
> >
> >
> > We should bump the version and republish the extension into VSCode 
> > marketplace. 
> >  @hokein has more context on how to properly do that.
>
>
> Once you commit this patch, I'm happy to make a new release.


OK, I'll commit as-is then. Thanks!


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D45285



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45285: [clangd-vscode] Update VScode dependencies

[Haojian Wu via Phabricator via cfe-commits]

hokein added a comment.

In https://reviews.llvm.org/D45285#1061243, @ilya-biryukov wrote:

> In https://reviews.llvm.org/D45285#1058567, @malaperle wrote:
>
> > Do we need to bump the version of the extension and do a new release or 
> > anything like that? Or leave this for later?
>
>
> We should bump the version and republish the extension into VSCode 
> marketplace. 
>  @hokein has more context on how to properly do that.


Once you commit this patch, I'm happy to make a new release.

> In https://reviews.llvm.org/D45285#1058578, @MaskRay wrote:
> 
>> Do we really want to keep editor plugins in the repository?
> 
> 
> As long as we are the ones who own it, probably yes. Any downsides to keeping 
> it here?

We used to have a separate GitHub repository for the extension, but it 
increased the maintaining burden (we need to syn whenever a new change is made 
in this repository).
Having the vscode extension in the clangd repository is the sensible way IMO.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D45285



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45285: [clangd-vscode] Update VScode dependencies

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added a subscriber: hokein.
ilya-biryukov added a comment.

In https://reviews.llvm.org/D45285#1058567, @malaperle wrote:

> Do we need to bump the version of the extension and do a new release or 
> anything like that? Or leave this for later?


We should bump the version and republish the extension into VSCode marketplace. 
@hokein has more context on how to properly do that.

In https://reviews.llvm.org/D45285#1058578, @MaskRay wrote:

> Do we really want to keep editor plugins in the repository?


As long as we are the ones who own it, probably yes. Any downsides to keeping 
it here?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D45285



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45285: [clangd-vscode] Update VScode dependencies

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added a comment.

Do we really want to keep editor plugins in the repository?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D45285



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45285: [clangd-vscode] Update VScode dependencies

[Marc-Andre Laperle via Phabricator via cfe-commits]

malaperle added a comment.

Do we need to bump the version of the extension and do a new release or 
anything like that? Or leave this for later?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D45285



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45285: [clangd-vscode] Update VScode dependencies

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov accepted this revision.
ilya-biryukov added a reviewer: ilya-biryukov.
ilya-biryukov added a comment.

LGTM


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D45285



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45285: [clangd-vscode] Update VScode dependencies

[Marc-Andre Laperle via Phabricator via cfe-commits]

malaperle created this revision.
Herald added subscribers: cfe-commits, MaskRay, ioeric, jkorous-apple, 
ilya-biryukov, klimek.
malaperle retitled this revision from "[clangd-vscode] Vscode dependencies" to 
"[clangd-vscode] Update VScode dependencies".

This allows the extension to work with LSP 3.0 and is useful for testing.

Signed-off-by: Marc-Andre Laperle 


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D45285

Files:
  clangd/clients/clangd-vscode/package.json


Index: clangd/clients/clangd-vscode/package.json
===
--- clangd/clients/clangd-vscode/package.json
+++ clangd/clients/clangd-vscode/package.json
@@ -6,7 +6,7 @@
 "publisher": "llvm-vs-code-extensions",
 "homepage": "https://clang.llvm.org/extra/clangd.html;,
 "engines": {
-"vscode": "^1.15.0"
+"vscode": "^1.18.0"
 },
 "categories": [
 "Languages",
@@ -32,12 +32,12 @@
 "test": "node ./node_modules/vscode/bin/test"
 },
 "dependencies": {
-"vscode-languageclient": "^3.3.0",
-"vscode-languageserver": "^3.3.0"
+"vscode-languageclient": "^4.0.0",
+"vscode-languageserver": "^4.0.0"
 },
 "devDependencies": {
 "typescript": "^2.0.3",
-"vscode": "^1.0.3",
+"vscode": "^1.1.0",
 "mocha": "^2.3.3",
 "@types/node": "^6.0.40",
 "@types/mocha": "^2.2.32"


Index: clangd/clients/clangd-vscode/package.json
===
--- clangd/clients/clangd-vscode/package.json
+++ clangd/clients/clangd-vscode/package.json
@@ -6,7 +6,7 @@
 "publisher": "llvm-vs-code-extensions",
 "homepage": "https://clang.llvm.org/extra/clangd.html;,
 "engines": {
-"vscode": "^1.15.0"
+"vscode": "^1.18.0"
 },
 "categories": [
 "Languages",
@@ -32,12 +32,12 @@
 "test": "node ./node_modules/vscode/bin/test"
 },
 "dependencies": {
-"vscode-languageclient": "^3.3.0",
-"vscode-languageserver": "^3.3.0"
+"vscode-languageclient": "^4.0.0",
+"vscode-languageserver": "^4.0.0"
 },
 "devDependencies": {
 "typescript": "^2.0.3",
-"vscode": "^1.0.3",
+"vscode": "^1.1.0",
 "mocha": "^2.3.3",
 "@types/node": "^6.0.40",
 "@types/mocha": "^2.2.32"
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits