djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
Comment at: lib/Format/TokenAnnotator.cpp:2276
+ // In Objective-C type declarations, prefer breaking after the category's
+ // close paren instead of after
True. I will reword the description to clarify.
On Thu, Apr 12, 2018, 07:58 Daniel Jasper via Phabricator <
revi...@reviews.llvm.org> wrote:
> djasper added a comment.
>
> I understand that, but the test example does not break after the closing
> paren. It breaks after the subsequent "<".
>
>
>
djasper added a comment.
I understand that, but the test example does not break after the closing paren.
It breaks after the subsequent "<".
Repository:
rC Clang
https://reviews.llvm.org/D45526
___
cfe-commits mailing list
Fair point. I'll update the diff description.
The net effect of the patch is to break after the closing paren; the way I
implemented that was to raise the penalty for breaking after the opening
paren.
On Thu, Apr 12, 2018, 06:37 Daniel Jasper via Phabricator <
revi...@reviews.llvm.org> wrote:
>
djasper added a comment.
Both patch and comment inside patch say "break after closing paren" and yet
that's not what the test or example in the description actually do. Why is that?
Repository:
rC Clang
https://reviews.llvm.org/D45526
___
benhamilton created this revision.
benhamilton added reviewers: djasper, jolesiak.
Herald added subscribers: cfe-commits, klimek.
Previously, `clang-format` would break Objective-C
category extensions after the opening parenthesis to avoid
breaking the protocol list:
% echo "@interface
