This revision was automatically updated to reflect the committed changes.
Closed by commit rC330596: [analyzer] Move `TaintBugVisitor` from
`GenericTaintChecker.cpp` to… (authored by henrywong, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D45682?vs=142621=143561#toc
george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.
> can add extra notes like
Ah right, than it's "can rely on" rather than "rely on".
> it is necessary to explicitly include
I've meant adding the include to
MTC added a comment.
In https://reviews.llvm.org/D45682#1074407, @george.karpenkov wrote:
> I'm new to the taint visitor, but I am quite confused by your change
> description.
>
> > and many checkers rely on it
>
> How can other checkers rely on it if it's private to the taint checker?
Thanks
george.karpenkov added a comment.
I'm new to the taint visitor, but I am quite confused by your change
description.
> and many checkers rely on it
How can other checkers rely on it if it's private to the taint checker?
Also, it's probably to explicitly include BugReporterVisitors.h in the
MTC created this revision.
MTC added reviewers: NoQ, george.karpenkov, xazax.hun.
Herald added subscribers: cfe-commits, a.sidorin, rnkovacs, szepet.
`TaintBugVisitor` is a universal visitor, and many checkers rely on it, such as
`ArrayBoundCheckerV2.cpp`, `DivZeroChecker.cpp` and
