mike.dvoretsky abandoned this revision.
mike.dvoretsky added a comment.
Closing this due to failure of https://reviews.llvm.org/D45721.
https://reviews.llvm.org/D45720
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
mike.dvoretsky updated this revision to Diff 144126.
mike.dvoretsky added a comment.
Changed the shuffle mask emission code to match https://reviews.llvm.org/D45721.
https://reviews.llvm.org/D45720
Files:
clang/lib/CodeGen/CGBuiltin.cpp
clang/test/CodeGen/avx2-builtins.c
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D45720
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
mike.dvoretsky updated this revision to Diff 142899.
mike.dvoretsky added a comment.
Updated per comments.
https://reviews.llvm.org/D45720
Files:
clang/lib/CodeGen/CGBuiltin.cpp
clang/test/CodeGen/avx2-builtins.c
clang/test/CodeGen/avx512bw-builtins.c
mike.dvoretsky added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:8443
+ Value *MaxVec = llvm::ConstantInt::get(RTy, MaxVal);
+ Res = EmitX86MinMax(CGF, ICmpInst::ICMP_SLT, {Res, MaxVec});
+ Res = EmitX86MinMax(CGF, ICmpInst::ICMP_SGT, {Res, MinVec});
craig.topper added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:8420
+ if (IsUnsigned) {
+MinVal = (IsDW) ? llvm::APInt::getMinValue(16).getZExtValue()
+: llvm::APInt::getMinValue(8).getZExtValue();
Why can't these just be
mike.dvoretsky created this revision.
mike.dvoretsky added reviewers: craig.topper, spatel.
Herald added a subscriber: cfe-commits.
This patch lowers the X86 vector packing with saturation intrinsics to native
LLVM IR. Comes with an LLVM patch.
Repository:
rC Clang
