[PATCH] D46942: Add vfs::FileSystem::getRealPath

2018-05-17 Thread Eric Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL332590: Add vfs::FileSystem::getRealPath (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D46942 Files:

[PATCH] D46942: Add vfs::FileSystem::getRealPath

2018-05-17 Thread Eric Liu via Phabricator via cfe-commits
ioeric added inline comments. Comment at: lib/Basic/FileManager.cpp:537 -#ifdef LLVM_ON_UNIX - char CanonicalNameBuf[PATH_MAX]; - if (realpath(Dir->getName().str().c_str(), CanonicalNameBuf)) + SmallString CanonicalNameBuf; + if (!FS->getRealPath(Dir->getName(),

[PATCH] D46942: Add vfs::FileSystem::getRealPath

2018-05-17 Thread Eric Liu via Phabricator via cfe-commits
ioeric updated this revision to Diff 147278. ioeric marked an inline comment as done. ioeric added a comment. - s/PATH_MAX/4096/ Repository: rC Clang https://reviews.llvm.org/D46942 Files: include/clang/Basic/VirtualFileSystem.h lib/Basic/FileManager.cpp

[PATCH] D46942: Add vfs::FileSystem::getRealPath

2018-05-17 Thread Benjamin Kramer via Phabricator via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Looks good. Please watch the windows buildbots carefully after landing this. Comment at: lib/Basic/FileManager.cpp:537 -#ifdef LLVM_ON_UNIX - char

[PATCH] D46942: Add vfs::FileSystem::getRealPath

2018-05-16 Thread Eric Liu via Phabricator via cfe-commits
ioeric updated this revision to Diff 147167. ioeric added a comment. - Add vfs::FileSystem::getRealPath; change getCanonicalName to use getRealPath Repository: rC Clang https://reviews.llvm.org/D46942 Files: include/clang/Basic/VirtualFileSystem.h lib/Basic/FileManager.cpp