NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
I've been thinking if we could de-duplicate this whole set of branches that
computes the return value so that we didn't have to fix every bug twice. Maybe
move it to an auxiliary function.
==
devnexen added a comment.
In https://reviews.llvm.org/D47007#1103551, @george.karpenkov wrote:
> Is it a fix for https://bugs.llvm.org/show_bug.cgi?id=37503 ?
Nope. more for last NoQ comment. Will try for this one once I finish setting it
up.
Repository:
rC Clang
https://reviews.llvm.org/
george.karpenkov added a comment.
Is it a fix for https://bugs.llvm.org/show_bug.cgi?id=37503 ?
Repository:
rC Clang
https://reviews.llvm.org/D47007
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
devnexen created this revision.
devnexen added reviewers: NoQ, george.karpenkov.
devnexen created this object with visibility "All Users".
Herald added a subscriber: cfe-commits.
Again strlc* does not return a pointer so the zero size case does not fit.
Repository:
rC Clang
https://reviews.ll
