[PATCH] D47092: downgrade strong type info names to weak_odr linkage

efriedma added a comment. Oh, you're right, sorry, the suggestion was to make asan instrumentation introduce the alias, not the frontend. In which case you'd want that fix plus D46665 , I think: external linkage optimizes better. Repository: rC Clang CHANG

[PATCH] D47092: downgrade strong type info names to weak_odr linkage

ldionne added a comment. In D47092#2049842 , @efriedma wrote: > I think the preferred solution is something like > https://bugs.llvm.org/show_bug.cgi?id=37545#c4, which is slightly different > from both this patch and D46665

[PATCH] D47092: downgrade strong type info names to weak_odr linkage

efriedma added a comment. I think the preferred solution is something like https://bugs.llvm.org/show_bug.cgi?id=37545#c4, which is slightly different from both this patch and D46665 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D47092: downgrade strong type info names to weak_odr linkage

ldionne added a comment. I'm revisiting http://llvm.org/PR37398 as it looks like a pretty serious bug to me. I read http://llvm.org/D46665, this patch and http://llvm.org/PR37545, and my understanding is that this patch supersedes @EricWF 's original patch http://llvm.org/D46665. The only rema

[PATCH] D47092: downgrade strong type info names to weak_odr linkage

rjmccall added inline comments. Comment at: test/CodeGenCXX/arm64.cpp:48 void A::foo() {} - // CHECK-GLOBALS-DAG: @_ZTSN5test21AE = constant [11 x i8] + // CHECK-GLOBALS-DAG: @_ZTSN5test21AE = weak_odr constant [11 x i8] // CHECK-GLOBALS-DAG: @_ZTIN5test21AE = constant {

[PATCH] D47092: downgrade strong type info names to weak_odr linkage

rsmith added a comment. In https://reviews.llvm.org/D47092#1105315, @efriedma wrote: > I'm pretty sure this isn't actually a violation of LLVM's linkage rules as > they are described in LangRef... at least, my understanding is that > "equivalent" doesn't imply anything about linkage. (If this

[PATCH] D47092: downgrade strong type info names to weak_odr linkage

EricWF added a comment. Sorry @rsmith, I was just about to tackle this. Repository: rC Clang https://reviews.llvm.org/D47092 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47092: downgrade strong type info names to weak_odr linkage

rjmccall added a comment. In https://reviews.llvm.org/D47092#1105317, @rjmccall wrote: > Incomplete classes are a curse. I don't suppose we can just modify the > language specification to make it illegal to use `typeid(Incomplete*)`? Or > make equality/hashing undefined in these cases? Hone

[PATCH] D47092: downgrade strong type info names to weak_odr linkage

rjmccall added a comment. Incomplete classes are a curse. I don't suppose we can just modify the language specification to make it illegal to use `typeid(Incomplete*)`? Or make equality/hashing undefined in these cases? Comment at: test/CodeGenCXX/arm64.cpp:48 void A::fo

[PATCH] D47092: downgrade strong type info names to weak_odr linkage

efriedma added a comment. > This results in formal violations of LLVM's linkage rules I'm pretty sure this isn't actually a violation of LLVM's linkage rules as they are described in LangRef... at least, my understanding is that "equivalent" doesn't imply anything about linkage. (If this shoul

[PATCH] D47092: downgrade strong type info names to weak_odr linkage

rsmith created this revision. rsmith added reviewers: EricWF, rjmccall, eli.friedman, jgorbe. Herald added a reviewer: javed.absar. After https://reviews.llvm.org/D46665 / https://reviews.llvm.org/rC332028, we now emit `linkonce_odr` definitions of type info names for incomplete class types. Thi