[PATCH] D47666: Refactored clang-fuzzer and added new (copy) files

kcc added a comment. Some feedback on the generated code: while (1){ let's not have the while loops inside the for loops for now. If the initial goal is to stress the loop optimizations (e.g. vectorizer), loops likes this are just a distraction for (int loop_ctr = 0 too verbose. Use

[PATCH] D47666: Refactored clang-fuzzer and added new (copy) files

This revision was automatically updated to reflect the committed changes. Closed by commit rL333969: [clang-proto-fuzzer] Refactored LLVMFuzzerInitialize into its own file. (authored by morehouse, committed by ). Changed prior to commit: https://reviews.llvm.org/D47666?vs=149872=149876#toc

[PATCH] D47666: Refactored clang-fuzzer and added new (copy) files

morehouse accepted this revision. morehouse added a comment. LGTM. Repository: rC Clang https://reviews.llvm.org/D47666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47666: Refactored clang-fuzzer and added new (copy) files

emmettneyman updated this revision to Diff 149872. emmettneyman added a comment. - Removed unecessary includes and renamed library. Repository: rC Clang https://reviews.llvm.org/D47666 Files: tools/clang-fuzzer/CMakeLists.txt tools/clang-fuzzer/ExampleClangProtoFuzzer.cpp

[PATCH] D47666: Refactored clang-fuzzer and added new (copy) files

morehouse added inline comments. Comment at: tools/clang-fuzzer/ExampleClangProtoFuzzer.cpp:23 #include I think `cstring` is no longer used after this change. So we can probably remove this include. Comment at:

[PATCH] D47666: Refactored clang-fuzzer and added new (copy) files

emmettneyman updated this revision to Diff 149867. emmettneyman added a comment. - Refactored FuzzerInitialize into library Repository: rC Clang https://reviews.llvm.org/D47666 Files: tools/clang-fuzzer/CMakeLists.txt tools/clang-fuzzer/ExampleClangProtoFuzzer.cpp

[PATCH] D47666: Refactored clang-fuzzer and added new (copy) files

morehouse added inline comments. Comment at: tools/clang-fuzzer/CMakeLists.txt:48 ExampleClangProtoFuzzer.cpp +FuzzerInitialize.cpp ) Rather than compiling `FuzzerInitialize.cpp` into the binary, can we make it a library like `handle-cxx` or

[PATCH] D47666: Refactored clang-fuzzer and added new (copy) files

emmettneyman added a comment. In https://reviews.llvm.org/D47666#1121608, @emmettneyman wrote: > - Updated and added header comments to two new files. Deleted loop fuzzer > files. I will commit the loop fuzzer files in a future patch. Repository: rC Clang https://reviews.llvm.org/D47666

[PATCH] D47666: Refactored clang-fuzzer and added new (copy) files

emmettneyman updated this revision to Diff 149854. emmettneyman added a comment. - Another edit to the file header comments. Repository: rC Clang https://reviews.llvm.org/D47666 Files: tools/clang-fuzzer/CMakeLists.txt tools/clang-fuzzer/ExampleClangProtoFuzzer.cpp

[PATCH] D47666: Refactored clang-fuzzer and added new (copy) files

emmettneyman updated this revision to Diff 149851. emmettneyman added a comment. - Fixed file header comment Repository: rC Clang https://reviews.llvm.org/D47666 Files: tools/clang-fuzzer/CMakeLists.txt tools/clang-fuzzer/ExampleClangProtoFuzzer.cpp

[PATCH] D47666: Refactored clang-fuzzer and added new (copy) files

emmettneyman updated this revision to Diff 149850. emmettneyman added a comment. - Updated and added header comments to two new files. Deleted loop fuzzer files. Repository: rC Clang https://reviews.llvm.org/D47666 Files: tools/clang-fuzzer/CMakeLists.txt

[PATCH] D47666: Refactored clang-fuzzer and added new (copy) files

vitalybuka requested changes to this revision. vitalybuka added inline comments. This revision now requires changes to proceed. Comment at: tools/clang-fuzzer/FuzzerInitialize.cpp:11 /// \file /// This file implements a function that runs Clang on a single /// input and uses

[PATCH] D47666: Refactored clang-fuzzer and added new (copy) files

emmettneyman updated this revision to Diff 149807. emmettneyman added a comment. - Changed CLArgs into getter and deleted commented code 1. Updating https://reviews.llvm.org/D47666: Refactored clang-fuzzer and added new (copy) files # 2. Enter a brief description of the changes included in this

[PATCH] D47666: Refactored clang-fuzzer and added new (copy) files

vitalybuka added a comment. In https://reviews.llvm.org/D47666#1119821, @vitalybuka wrote: > Good practice is to avoid merging changes into a single one. > Here one patch should be "refactoring" and the second for > "loop-proto-fuzzer." We are doing this for several reasons: 1. smaller

[PATCH] D47666: Refactored clang-fuzzer and added new (copy) files

vitalybuka added a comment. Good practice is to avoid merging changes into a single one. Here one patch should be "refactoring" and the second for "loop-proto-fuzzer." Comment at: tools/clang-fuzzer/ExampleClangProtoFuzzer.cpp:29 +/* static std::vector CLArgs;

[PATCH] D47666: Refactored clang-fuzzer and added new (copy) files

emmettneyman updated this revision to Diff 149585. emmettneyman added a comment. - Took out a debug print statement Repository: rC Clang https://reviews.llvm.org/D47666 Files: tools/clang-fuzzer/CMakeLists.txt tools/clang-fuzzer/ExampleClangProtoFuzzer.cpp

[PATCH] D47666: Refactored clang-fuzzer and added new (copy) files

emmettneyman created this revision. emmettneyman added reviewers: vitalybuka, kcc, morehouse. Herald added subscribers: cfe-commits, mgorny. Refactored LLVMFuzzerInitialize function into its own file. Copied and renamed some files in preparation for new loop-proto-fuzzer. Repository: rC Clang