martong abandoned this revision.
martong added a comment.
Closed in favor of https://reviews.llvm.org/D47632
Repository:
rC Clang
https://reviews.llvm.org/D48722
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
martong added a comment.
> I have a strong feeling of duplication with attribute and flags merging move
> in https://reviews.llvm.org/D47632. Maybe it is better to be resolved in that
> review by using the same code for attr/flag merging for both newly-created
> and mapped decls?
Ok, then
balazske added a comment.
Originally this change was made after the patch in
https://reviews.llvm.org/D47632 was done. It is here back-ported to the state
before it. I like the idea of integrating this change into
https://reviews.llvm.org/D47632. (This is a new functionality: Attributes are
a.sidorin added a comment.
Whoops, sorry Balázs. Didn't look at the review author :(
Repository:
rC Clang
https://reviews.llvm.org/D48722
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
a.sidorin added a comment.
Hello Gabor,
I have a strong feeling of duplication with attribute and flags merging move in
https://reviews.llvm.org/D47632. Maybe it is better to be resolved in that
review by using the same code for attr/flag merging for both newly-created and
mapped decls?
balazske created this revision.
Herald added subscribers: cfe-commits, martong.
Herald added a reviewer: a.sidorin.
When a Decl is imported over an already existing similar one,
the isUsed flag is updated if it is set in the imported Decl.
This can happen if the Decl is used somewhere in the
