This revision was automatically updated to reflect the committed changes.
Closed by commit rC336842: Fix setting of empty implicit-section-name attribute
(authored by petr.pavlu, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D48916
Files:
lib/CodeGen/CodeGenModule.cpp
test
chill accepted this revision.
chill added a comment.
This revision is now accepted and ready to land.
LGTM. Please, wait a couple of days before committing to give a chance to
someone else to weigh in.
Repository:
rC Clang
https://reviews.llvm.org/D48916
__
petpav01 added inline comments.
Comment at: test/CodeGen/clang-sections-attribute.c:1
+// RUN: %clang_cc1 -emit-llvm -triple arm-none-eabi -o - %s | FileCheck %s
+
chill wrote:
> Isn't it possible for the test to fail if the Arm target is not configured?
I think
chill added inline comments.
Comment at: test/CodeGen/clang-sections-attribute.c:1
+// RUN: %clang_cc1 -emit-llvm -triple arm-none-eabi -o - %s | FileCheck %s
+
Isn't it possible for the test to fail if the Arm target is not configured?
Repository:
rC Clang
petpav01 created this revision.
petpav01 added reviewers: javed.absar, chill, rnk.
Herald added subscribers: cfe-commits, kristof.beyls.
Code in `CodeGenModule::SetFunctionAttributes()` can set an empty attribute
`implicit-section-name` on a function that is affected by `#pragma clang
text="sect
