[PATCH] D49188: [OpenMP] Initialize data sharing stack for SPMD case

2018-07-13 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL337015: [OpenMP] Initialize data sharing stack for SPMD case (authored by gbercea, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D49188 Files:

[PATCH] D49188: [OpenMP] Initialize data sharing stack for SPMD case

2018-07-13 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang https://reviews.llvm.org/D49188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49188: [OpenMP] Initialize data sharing stack for SPMD case

2018-07-13 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
gtbercea updated this revision to Diff 155391. gtbercea added a comment. Fix tests. Repository: rC Clang https://reviews.llvm.org/D49188 Files: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp test/OpenMP/nvptx_data_sharing.cpp test/OpenMP/nvptx_target_parallel_codegen.cpp

[PATCH] D49188: [OpenMP] Initialize data sharing stack for SPMD case

2018-07-12 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: test/OpenMP/nvptx_data_sharing.cpp:33 // CK1: call void @llvm.nvvm.barrier0() -// CK1: call void @__kmpc_data_sharing_init_stack It is better to check that this call is not emitted, like this `CK1-NOT: call void

[PATCH] D49188: [OpenMP] Initialize data sharing stack for SPMD case

2018-07-11 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
gtbercea marked 2 inline comments as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:84-85 OMPRTL_NVPTX__kmpc_data_sharing_init_stack, + /// Call to void __kmpc_data_sharing_init_stack_spmd(); +

[PATCH] D49188: [OpenMP] Initialize data sharing stack for SPMD case

2018-07-11 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
gtbercea updated this revision to Diff 155037. gtbercea added a comment. Add test for spmd stack init function. Repository: rC Clang https://reviews.llvm.org/D49188 Files: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp test/OpenMP/nvptx_data_sharing.cpp test/OpenMP/nvptx_data_sharing_spmd.cpp

[PATCH] D49188: [OpenMP] Initialize data sharing stack for SPMD case

2018-07-11 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:84-85 OMPRTL_NVPTX__kmpc_data_sharing_init_stack, + /// Call to void __kmpc_data_sharing_init_stack_spmd(); + OMPRTL_NVPTX__kmpc_data_sharing_init_stack_spmd, /// Call to void*

[PATCH] D49188: [OpenMP] Initialize data sharing stack for SPMD case

2018-07-11 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
gtbercea updated this revision to Diff 155002. gtbercea added a comment. Fix test. Repository: rC Clang https://reviews.llvm.org/D49188 Files: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp test/OpenMP/nvptx_data_sharing.cpp Index: test/OpenMP/nvptx_data_sharing.cpp

[PATCH] D49188: [OpenMP] Initialize data sharing stack for SPMD case

2018-07-11 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. What about the check for the new function call? Repository: rC Clang https://reviews.llvm.org/D49188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49188: [OpenMP] Initialize data sharing stack for SPMD case

2018-07-11 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. Tests? Repository: rC Clang https://reviews.llvm.org/D49188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits